Add automatic OData filter sanitization#106
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Introduce a composite flag so or/any results parenthesize themselves only when combined with and, preventing the OData operator-precedence trap where 'A or B and C' is silently misread as 'A or (B and C)'. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
alphahlee
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model/odata.tswith escaping primitives (odataString,odataValue) and a composableFilterbuilder that automatically escapes string values — fixing searches that broke when a value contained a single quote (e.g. an email/name likeO'Brien).Filter.contains(field, value)forcontains(...)predicates, escaping the value viaodataStringand composing with.and/.or/Filter.anylike the other builders.QueryContext.setFilterto acceptstring | Filter(non-breaking — existing string callers are unchanged) and exports the new module fromindex.ts.UserName,DisplayName) infamis_client.tsto theFilterbuilder. Numeric-ID filters are intentionally left as-is and can be migrated incrementally.Filtercomposition is precedence-safe: composite operands are parenthesized when combined, since OData bindsandtighter thanor.Design and implementation plan:
docs/superpowers/specs/2026-06-02-odata-filter-sanitization-design.md,docs/superpowers/plans/2026-06-02-odata-filter-sanitization.md.Test Plan
odata.ts(escaping, type dispatch, builder composition incl. precedence safety)Filter.contains(escaping + composition)QueryContext.setFilter(Filter)renders the escaped$filterend-to-end via URL parsingtscbuild clean🤖 Generated with Claude Code