update gem tooling and support matrix#83
Merged
Merged
Conversation
- exception_safety_spec: disallow_phi/allow_phi/get_phi block exception safety (class + instance) - require_phi_spec: PhiAccessException raised/not-raised under class and instance access - disallow_last_phi_spec: pops most recent allow, no-op on empty stack - phi_allowed_by_spec: nil when no access, correct user_id/reason, stacked allows, class fallback - log_sanitization_spec: newlines stripped from user_id and reason at allow_phi! entry - request_isolation_spec: class allow cleared by RequestStore.clear!, instance stack survives, extended instances cleared - rspec_matcher_spec: allow_phi_access positive/negative, allowed_by/with_access_reason chains, negated raises ArgumentError Also fix PhiAccessException unqualified constant in require_phi! (was PhiAccessException, now PhiAttrs::Exceptions::PhiAccessException)
PhiStackEntry = Struct.new(:phi_access_allowed, :user_id, :reason, :logged, keyword_init: true)
Structs are cheaper to allocate than Hashes and expose named accessors.
Replaces every push({...}) and [:key] access site in both class-level
and instance-level stacks.
egreer
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.