Skip to content

Mixed naming of central and peripheral in examples#232

Open
mklemarczyk wants to merge 1 commit intoarduino-libraries:masterfrom
mklemarczyk:hotfix/example-variable-naming
Open

Mixed naming of central and peripheral in examples#232
mklemarczyk wants to merge 1 commit intoarduino-libraries:masterfrom
mklemarczyk:hotfix/example-variable-naming

Conversation

@mklemarczyk
Copy link
Copy Markdown
Contributor

Fixed the names and comments to not confuse the users.

The BLE central can start connection to peripheral, not vice versa.

The most confusing one was that we wait for peripherals to connect, and next comment name the variable that it is central. :)

  // listen for Bluetooth® Low Energy peripherals to connect:
  BLEDevice central = BLE.central();

Fixed the names and comments to not confuse the users.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: documentation Related to documentation for the project labels Apr 7, 2022
@mklemarczyk
Copy link
Copy Markdown
Contributor Author

What I can do to accelerate approval of that PR ?

@mklemarczyk
Copy link
Copy Markdown
Contributor Author

@facchinm You do not want this change? There are several PRs waiting, and no comment or merged.

@mklemarczyk
Copy link
Copy Markdown
Contributor Author

Bump, any answer on the integration ? I wonder why it takes so long...

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants