fix solve time for logical dispatch model#73
Merged
Conversation
Collaborator
Author
|
@SamarAbdelkawy, I'm adding you as a reviewer to this pull request since you might be interested in using Osier at some point! |
katyhuff
approved these changes
Jul 3, 2025
katyhuff
left a comment
Member
There was a problem hiding this comment.
Looks good, reviewed together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR adds addresses a bug that caused a major slowdown for the logical dispatch model when using it with the
CapacityExpansionproblem. I fixed the issue by removing the call forsynchronize_unitswithin the baseModelclass since users can do this manually andCapacityExpansionwill do it by default. It should only happen once, but was instead happening for every evaluation.Types of changes
Associated Issues and PRs
Associated Developers
Checklist for Reviewers
Reviewers should use this link to get to the
Review Checklist before they begin their review.