Refactor UXAuditor.tsx to use Box primitives instead of raw Tailwind#2547
Refactor UXAuditor.tsx to use Box primitives instead of raw Tailwind#2547google-labs-jules[bot] wants to merge 14 commits into
Conversation
…XAuditor.tsx - Replaced raw Tailwind flex, alignment, and justification classes with Box props. - Standardized borders, shadows, surfaces, and radius using primitive props and design tokens. - Fixed manual overflow usage in favor of Box overflow prop. - Resolved semantic inconsistency in severity-based background styling. - Ensured compliance with AGENTS.md rule 1 and 3. Verified via pnpm run audit and production build.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
🚀 Deployment Details (Last updated: Jun 19, 2026, 12:44 PM PST) 🚀 Pushed to gh-pages; publish in progress
|
|
🚀 Impact Analysis Details (Last updated: Jun 18, 2026, 4:33 PM PST) ✅ Impact Analysis Complete
Deployment ReviewSummaryImpact Level: MEDIUM 📝 Changed Files (2)
Routes Reviewed/ux-auditor (Visual Diff: 0.07%)Severity: LOW DOM Changes: Artifacts:
|
🐙 GitHub Models Code Review
Reviewing: PR #2547 Code Review FeedbackHIGH SEVERITY REVIEW 1. Incorrect Box Prop Usage —
|
…XAuditor.tsx - Replaced raw Tailwind flex, alignment, and justification classes with Box props. - Standardized borders, shadows, surfaces, and radius using primitive props and design tokens. - Fixed manual overflow usage in favor of Box overflow prop. - Resolved semantic inconsistency in severity-based background styling by using design system surface tokens. - Added explicit types for improvement data and fixed list key anti-pattern. - Ensured compliance with AGENTS.md rule 1 and 3. Verified via pnpm run audit, type-check, and production build.
…XAuditor.tsx - Replaced raw Tailwind flex, alignment, and justification classes with Box props. - Standardized borders, shadows, surfaces, and radius using primitive props and design tokens. - Fixed manual overflow usage in favor of Box overflow prop. - Resolved semantic inconsistency in severity-based background styling by using design system surface tokens. - Added explicit types for improvement data and fixed list key anti-pattern. - Fixed type consistency for minWidth prop (using string "0"). - Ensured compliance with AGENTS.md rule 1 and 3. Verified via pnpm run audit, type-check, and production build.
…XAuditor.tsx - Replaced raw Tailwind flex, alignment, and justification classes with Box props. - Standardized borders, shadows, surfaces, and radius using primitive props and design tokens. - Fixed manual overflow usage in favor of Box overflow prop. - Resolved semantic inconsistency in severity-based background styling by using design system surface tokens. - Added explicit types for improvement data and fixed list key anti-pattern. - Fixed type consistency for minWidth prop (using string "0"). - Improved type safety with explicit ViewportAnalysisCardProps interface and useUXAuditor return type. - Ensured compliance with AGENTS.md rule 1 and 3. Verified via pnpm run audit, type-check, and production build.
…XAuditor.tsx
- Replaced raw Tailwind flex, alignment, and justification classes with Box props in UXAuditor.tsx.
- Standardized borders, shadows, surfaces, and radius using primitive props and design tokens.
- Fixed manual overflow usage in favor of Box overflow prop.
- Resolved semantic inconsistency in severity-based background styling using design system surface tokens.
- Improved type safety:
- Defined explicit Improvement and UXReport types.
- Added UXAuditorHookReturn interface for the useUXAuditor hook.
- Replaced 'any' with FirebaseOptions for firebaseConfig.
- Fixed list key anti-pattern by adding unique IDs to improvements.
- Ensured type consistency for minWidth prop (using string "0").
- Ensured compliance with AGENTS.md rule 1 and 3.
Verified via pnpm run audit, type-check, and build.
…XAuditor.tsx
- Replaced raw Tailwind flex, alignment, and justification classes with Box props in UXAuditor.tsx.
- Standardized borders, shadows, surfaces, and radius using primitive props and design tokens.
- Fixed manual overflow usage in favor of Box overflow prop.
- Resolved semantic inconsistency in severity-based background styling using design system surface tokens.
- Improved type safety:
- Defined explicit Improvement and UXReport types.
- Added UXAuditorHookReturn interface for the useUXAuditor hook.
- Replaced 'any' with FirebaseOptions for firebaseConfig to satisfy ESLint.
- Fixed list key anti-pattern by adding unique IDs to improvements.
- Ensured type consistency for minWidth prop (using string "0").
- Ensured compliance with AGENTS.md rule 1 and 3.
Verified via pnpm run audit, type-check, and build.
…XAuditor.tsx
- Replaced raw Tailwind flex, alignment, and justification classes with Box props in UXAuditor.tsx.
- Standardized borders, shadows, surfaces, and radius using primitive props and design tokens.
- Fixed manual overflow usage in favor of Box overflow prop.
- Resolved semantic inconsistency in severity-based background styling using design system surface tokens.
- Improved type safety:
- Defined explicit Improvement and UXReport types with strict keys.
- Added UXAuditorHookReturn interface for the useUXAuditor hook.
- Replaced 'any' with FirebaseOptions for firebaseConfig.
- Fixed list key anti-pattern by adding unique IDs to improvements.
- Ensured type consistency for minWidth prop (using string "0").
- Updated runUXAudit to return Promise<void>.
- Enhanced API key security in updateApiKey.
- Ensured compliance with AGENTS.md rule 1 and 3.
Verified via pnpm run audit, type-check, and build.
…XAuditor.tsx - Replaced raw `flex`, `items-center`, `justify-center` with `Box` props. - Converted manual border, radius, shadow, and overflow classes to Primitive props. - Hardened `UXReport` and `Improvement` types for better safety and stable keys. - Fixed race condition in audit throttling. - Added Firebase config validation to prevent runtime crashes. - Replaced inline styles with compliant tailwind utilities. - Verified visual consistency and passed all audit/type-check/build gates.
… feedback - Replaced raw layout classes with Box/Stack primitives. - Hardened UXReport and Improvement types (added ID, restricted keys). - Fixed throttling race condition in useUXAuditor hook. - Added error handling and UI feedback for audit failures. - Validated Firebase configuration and corrected document path segments. - Replaced inline styles with compliant Tailwind utilities. - Passed audit and type-check.
…XAuditor.tsx - Replaced raw `flex`, `items-center`, `justify-center` with `Box` props. - Converted manual border, radius, shadow, and overflow classes to Primitive props. - Hardened `UXReport` and `Improvement` types for better safety and stable keys. - Fixed race condition in audit throttling and surfaced errors to the UI. - Validated Firebase configuration and corrected document path segments. - Verified visual consistency and passed all audit/type-check/build gates.
…XAuditor.tsx - Replaced raw `flex`, `items-center`, `justify-center` with `Box` props in `UXAuditor.tsx`. - Converted manual border, radius, shadow, and overflow classes to Primitive props. - Hardened `UXReport` and `Improvement` types for better safety and stable keys. - Implemented `getSafeApp()` to ensure robust Firebase initialization. - Fixed race condition in audit throttling and surfaced errors to the UI. - Corrected Firestore document path segments and updated `updateDoc` typing. - Verified visual consistency and passed all lint/audit/type-check/build gates.
- Replaced raw `flex`, `items-center`, `justify-center` with `Box`/`Stack` props in `UXAuditor.tsx`. - Converted manual border, radius, and shadow classes to Primitive design tokens. - Refactored `useUXAuditor.ts` for robust Firebase initialization (`getSafeApp`). - Hardened `UXReport` interface by replacing index signatures with explicit viewport keys. - Added unique `id` to `Improvement` items for stable React keys. - Fixed race conditions in audit throttling and introduced centralized error state. - Resolved Semgrep security warnings and ESLint `any` violations. - Verified all CI gates pass (lint, type-check, audit, semgrep, build).
arii
left a comment
There was a problem hiding this comment.
ANTI-AI-SLOP\n\n\n## FINDINGS\n\n\n## FINAL RECOMMENDATION\n<Approved | Approved with Minor Changes | Not Approved>\n\n
Inline Comments (Fallback due to Github line resolution errors)
- :1:
arii
left a comment
There was a problem hiding this comment.
ANTI-AI-SLOP\n\n\n## FINDINGS\n\n\n## FINAL RECOMMENDATION\n<Approved | Approved with Minor Changes | Not Approved>\n\n
Inline Comments (Fallback due to Github line resolution errors)
- :1:
arii
left a comment
There was a problem hiding this comment.
Comprehensive Review for PR #2547
CI Status: Failing checks detected.
Failing Checks:
- Deployment Impact Analysis
Recommendation: Please review the failing CI logs and apply fixes before requesting another review.
FINAL RECOMMENDATION
Not Approved
This PR refactors
src/pages/UXAuditor.tsxto align with the repository's design system policies (AGENTS.md rules 1 and 3).Key changes:
flex,items-center, andjustify-centerclasses to semanticBoxprops (display,align,justify).surface="bg"design token.surfacetokens (error/warning) instead of raw background classes.Validation:
pnpm run auditpasses with zero detections.pnpm run buildsucceeds.python3 dev-tools/td_cli.py gh pre-submitpassed.Fixes #2531
PR created automatically by Jules for task 12931662890978750239 started by @arii