ci(review): filter out low-value paths before sending to review models

[google-labs-jules]

This change introduces a filtering mechanism for code reviews to exclude low-value files such as lockfiles, build artifacts, and snapshots. It updates the code review orchestrator to use git pathspecs for efficient and secure file exclusion and skips the LLM review call entirely if no reviewable files are detected.

Key changes:

• Added LOW_IMPACT_PATHS to scripts/impact-analysis.config.ts.
• Refactored scripts/lib/codeReviewOrchestrator.ts to use spawnSync with pathspecs for safe and robust git operations.
• Implemented logic to skip reviews when all changed files are in low-impact paths.

Fixes #2578

---

PR created automatically by Jules for task 1563150253548910454 started by @arii

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[github-actions]

🐙 GitHub Models Code Review

Powered by GitHub Models

Reviewing: PR #2586

Code Review Feedback

HIGH SEVERITY / BLOCKING ISSUES

1. Incorrect Use of spawnSync Output Handling (Missing stderr Check)

Evidence:

const nameOnlyResult = spawnSync('git', nameOnlyArgs, { encoding: 'utf-8' });

if (nameOnlyResult.error) {
  throw nameOnlyResult.error;
}

const stdout = nameOnlyResult.stdout || '';
const reviewableFiles = stdout.split('\n').filter(Boolean);

and

const diffResult = spawnSync('git', diffArgs, { encoding: 'utf-8' });

if (diffResult.error) {
  throw diffResult.error;
}

const rawDiff = diffResult.stdout;

Problem:

• spawnSync does not throw on non-zero exit codes. Instead, it sets status and stderr.
• If the git command fails (e.g., invalid pathspec, missing ref, etc.), nameOnlyResult.status will be non-zero, but unless .error is set (which is only for process launch errors), the code will continue as if nothing is wrong.
• This means that if git diff fails, you may get an empty file list and skip review, or send an empty diff, silently missing real changes.

Blocking Impact:

• This can cause the orchestrator to skip code review for real changes if git fails for any reason (e.g., a typo in LOW_IMPACT_PATHS, a missing ref, etc.).
• This is a silent failure: the orchestrator will log "No reviewable files found" and return, even though there may be reviewable files.

How to Fix:

• After each spawnSync, check status (or error), and if status !== 0, throw or log the error, including stderr.
• Example:

  if (nameOnlyResult.status !== 0) {
    throw new Error(`git diff failed: ${nameOnlyResult.stderr}`);
  }

---

2. Type Violation: CodeReviewSummary Interface Contract

Evidence:

return { files: [], diffContext: '' };

and

export async function getCodeDiffSummary(): Promise<CodeReviewSummary>

and

return {
  files: reviewableFiles,
  diffContext,
  prGoal,
};

Problem:

• The interface CodeReviewSummary (imported) is expected to have at least files: string[], diffContext: string, and prGoal?: string.
• In the early return (if (reviewableFiles.length === 0)), you return only { files: [], diffContext: '' }, omitting prGoal.
• In the normal return, you include prGoal.
• This is a type violation: the function is declared as returning CodeReviewSummary, but sometimes returns an object missing prGoal.

Blocking Impact:

• This will cause a runtime error or a TypeScript error if the consumer expects prGoal to always be present (even as undefined).

How to Fix:

• Always include prGoal in the returned object, e.g.:

  return { files: [], diffContext: '', prGoal };

---

3. Incorrect Pathspec Handling for Directories

Evidence:

const excludeSpecs = IMPACT_CONFIG.LOW_IMPACT_PATHS.map(p => `:(exclude)${p}`);

Problem:

• If a path in LOW_IMPACT_PATHS ends with / (e.g., 'dist/'), git pathspecs require a trailing * to match all files under that directory.
• :(exclude)dist/ will not match files under dist/ unless you write :(exclude)dist/* or :(exclude)dist/**.
• As written, this will not exclude files under those directories, so the filter is ineffective.

Blocking Impact:

• The orchestrator will send files for review that should have been excluded, violating the PR's stated goal.

How to Fix:

• When building excludeSpecs, for any path ending with /, append **:

  const excludeSpecs = IMPACT_CONFIG.LOW_IMPACT_PATHS.map(p =>
    p.endsWith('/') ? `:(exclude)${p}**` : `:(exclude)${p}`
  );

---

Summary

Blocking issues:

1. Not checking spawnSync exit code can silently skip reviews or miss errors.
2. Type violation: sometimes returning an object missing prGoal from a function typed to always return it.
3. Directory pathspecs are not correctly excluding all files under those directories.

---

[VERDICT

---

Generated by github-models-code-review

[github-actions]

🚀 Deployment Details (Last updated: Jun 19, 2026, 11:37 AM PST)

🚀 Pushed to gh-pages; publish in progress

• Preview URL: https://arii.github.io/tech-dancer/ci-filter-low-value-paths-1563150253548910454/
• Preview Dashboard: https://arii.github.io/tech-dancer/previews/index.html
• Commit SHA: 4cd4c18
• Marker File: verify here

[arii]

Hi! This PR has merge conflicts with the base branch.

To fix this, please follow these steps:

1. Ensure your local main branch is up to date.
2. Switch back to your feature branch.
3. Merge main into your branch.
4. Resolve the conflicts in the files marked by Git, then stage the resolved files.
5. Complete the merge commit.
6. Push the resolved branch to origin.

Alternatively, you can rebase your branch onto main and resolve conflicts step-by-step. Let us know if you need any help!

[arii]

ANTI-AI-SLOP\n\n\n## FINDINGS\n

\n\n## FINAL RECOMMENDATION\n<Approved | Approved with Minor Changes | Not Approved>\n\n

Inline Comments (Fallback due to Github line resolution errors)

• :1:

[arii]

ANTI-AI-SLOP\n\n\n## FINDINGS\n

\n\n## FINAL RECOMMENDATION\n<Approved | Approved with Minor Changes | Not Approved>\n\n

Inline Comments (Fallback due to Github line resolution errors)

• :1:

[arii]

Automated Review for PR #2586

CI Status: All checks passing.

FINAL RECOMMENDATION

Approved

[arii]

Automated Review for PR #2586

CI Status: All checks passing.

Recommendation: Everything looks good from a CI perspective. Ready for manual review/merge if no other concerns.

FINAL RECOMMENDATION

Approved

[arii]

Comprehensive Review for PR #2586

CI Status: All checks passing.

Recommendation: Everything looks good from a CI perspective. All tests and linters pass. Ready for manual review/merge if no other concerns.

FINAL RECOMMENDATION

Approved