ci(review): feed full type/interface context into the reviewer

[google-labs-jules]

This change addresses the issue where the AI code reviewer would "hedge" its advice because it lacked the full type or interface definitions of components and constants used in a diff.

Key improvements:

• Context Gathering: The orchestrator now parses imports from changed files and identifies which imported symbols (like Box or SPACING_MAP) are actually used in the diff hunks.
• Source Resolution: It resolves these symbols to their source files (supporting @/ aliases and relative paths) and includes their full content in the review prompt.
• Safety: Context is capped at 30,000 characters to manage token usage and prevent context window overflow.
• Robustness: Updated the fallback diff logic to use main...HEAD for better coverage of branch history.
• Precision: Fixed handling of import { type Symbol } syntax in the import parser.

Verified with a test script that successfully pulled in definitions for Box.tsx and layout-maps.ts when they were referenced in a dummy component's diff.

Fixes #2570

---

PR created automatically by Jules for task 14479273981206446606 started by @arii

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[github-actions]

🚀 Deployment Details (Last updated: Jun 19, 2026, 11:15 AM PST)

🚀 Pushed to gh-pages; publish in progress

• Preview URL: https://arii.github.io/tech-dancer/jules-14479273981206446606-950610a2/
• Preview Dashboard: https://arii.github.io/tech-dancer/previews/index.html
• Commit SHA: e5f1690
• Marker File: verify here

[github-actions]

🐙 GitHub Models Code Review

Powered by GitHub Models

Reviewing: PR #2591

Code Review Feedback

HIGH SEVERITY REVIEW

1. Blocking Bug: Regex for Symbol Usage Detection

Location:
codeReviewOrchestrator.ts, in the loop:

for (const [symbol, importPath] of imports.entries()) {
  const symbolRegex = new RegExp(`\\b${symbol}\\b`);
  if (symbolRegex.test(fileDiff)) {
    const resolved = resolveImportPath(importPath, file);
    if (resolved) externalFilePaths.add(resolved);
  }
}

Issue:
The code attempts to detect whether an imported symbol is used in the diff by constructing a regex from the symbol name. However, if the symbol contains special regex characters (e.g., $, ., (, ), [, ], etc.), this will cause the regex to be invalid or match unintended text.
Example:
If a symbol is named Box$, the regex will be /\bBox$\b/, which is invalid and will throw an error.

Blocking Impact:
If any imported symbol contains a regex metacharacter, this code will throw and skip context gathering for the file, leading to missing context and potentially incorrect reviews.

Action:
You must escape the symbol before constructing the regex. Use RegExp.escape (if available) or implement your own escaping function.

---

2. Blocking Bug: Use of RegExp.escape (Not Standard)

Location:
Same as above.

Issue:
Node.js does not provide a built-in RegExp.escape function. If you attempt to use it, it will throw.
Action:
You must implement your own escaping function, e.g.:

function escapeRegExp(string: string): string {
  return string.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
}

And use:

const symbolRegex = new RegExp(`\\b${escapeRegExp(symbol)}\\b`);

---

3. Blocking Bug: externalContext.length > maxExternalChars Check

Location:

for (const extPath of externalFilePaths) {
  if (externalContext.length > maxExternalChars) break;
  ...
}

Issue:
This check is off-by-one:

• If externalContext.length is equal to maxExternalChars, the loop will continue and append more content, exceeding the cap.
• The cap is only enforced after the loop, via slicing and appending ...[TRUNCATED EXTERNAL CONTEXT].

Blocking Impact:
You may exceed the intended context cap, causing token overflow and potentially breaking downstream consumers.

Action:
Change the check to >=:

if (externalContext.length >= maxExternalChars) break;

---

4. Blocking Bug: Fallback Diff Command

Location:

try {
    execSync('git rev-parse origin/main', { stdio: 'ignore' });
} catch {
    diffCommand = 'git diff main...HEAD';
    nameOnlyCommand = 'git diff --name-only main...HEAD';
}

Issue:
If origin/main does not exist, the fallback uses main...HEAD. However, if main does not exist locally (e.g., in a shallow clone or CI environment), this will throw and cause the entire diff generation to fail.

Blocking Impact:
If neither origin/main nor main exists, the code will not generate a diff, and the review will be skipped or fail.

Action:
You must add an additional fallback, e.g., to HEAD~1 HEAD, as was previously done.
Example fix:

try {
    execSync('git rev-parse origin/main', { stdio: 'ignore' });
} catch {
    try {
        execSync('git rev-parse main', { stdio: 'ignore' });
        diffCommand = 'git diff main...HEAD';
        nameOnlyCommand = 'git diff --name-only main...HEAD';
    } catch {
        diffCommand = 'git diff HEAD~1 HEAD';
        nameOnlyCommand = 'git diff --name-only HEAD~1 HEAD';
    }
}

---

5. Blocking Bug: externalContext.trim() || undefined

Location:

externalContext: externalContext.trim() || undefined,

Issue:
If externalContext is an empty string, this will set externalContext to undefined. However, in the client code:

if (summary.externalContext) {
  baseContent.push({ ... });
}

This is correct, but if externalContext is a string containing only whitespace, it will be trimmed to '' and set to `

---

Generated by github-models-code-review

[arii]

Hi! This PR has merge conflicts with the base branch.

To fix this, please follow these steps:

1. Ensure your local main branch is up to date.
2. Switch back to your feature branch.
3. Merge main into your branch.
4. Resolve the conflicts in the files marked by Git, then stage the resolved files.
5. Complete the merge commit.
6. Push the resolved branch to origin.

Alternatively, you can rebase your branch onto main and resolve conflicts step-by-step. Let us know if you need any help!

[arii]

ANTI-AI-SLOP\n\n\n## FINDINGS\n

\n\n## FINAL RECOMMENDATION\n<Approved | Approved with Minor Changes | Not Approved>\n\n

Inline Comments (Fallback due to Github line resolution errors)

• :1:

[arii]

ANTI-AI-SLOP\n\n\n## FINDINGS\n

\n\n## FINAL RECOMMENDATION\n<Approved | Approved with Minor Changes | Not Approved>\n\n

Inline Comments (Fallback due to Github line resolution errors)

• :1:

[arii]

Automated Review for PR #2591

CI Status: All checks passing.

FINAL RECOMMENDATION

Approved

[arii]

Automated Review for PR #2591

CI Status: All checks passing.

Recommendation: Everything looks good from a CI perspective. Ready for manual review/merge if no other concerns.

FINAL RECOMMENDATION

Approved

[arii]

Comprehensive Review for PR #2591

CI Status: All checks passing.

Recommendation: Everything looks good from a CI perspective. All tests and linters pass. Ready for manual review/merge if no other concerns.

FINAL RECOMMENDATION

Approved

[arii]

🤖 AI Technical Audit

ANTI-AI-SLOP

The regex-based parser in codeReviewOrchestrator.ts is fragile and prone to edge cases (e.g., multiline imports, complex destructured imports with nested objects, or aliased exports). Implementing a regex-based parser for JavaScript/TypeScript is an anti-pattern that creates technical debt. Additionally, the file resolution logic reimplements resolve mechanics that Node.js require.resolve or TypeScript's compilerOptions handle natively.

While the goal of providing external context is valid, hard-coding a custom parser and path resolution logic in a script is over-engineering.

FINAL RECOMMENDATION

Approved with Minor Changes

Review automatically published via RepoAuditor.