Conversation
yejseo01
force-pushed
the
better-changelog
branch
from
96a537a to
880ebc0
Compare
awphi
left a comment
awphi
left a comment
There was a problem hiding this comment.
Nothing blocking from me but a couple small observations
| exclude: | ||
| - "^docs:" | ||
| - "^chore:" |
There was a problem hiding this comment.
Should also hide refactor, test and style?
Also not sure if we should exclude docs - has some user value
| regexp: '^.*?feat(\([[:word:]]+\))??:.*$' | ||
| order: 1 | ||
| - title: Bug Fixes | ||
| regexp: '^.*?fix(\([[:word:]]+\))??:.*$' |
There was a problem hiding this comment.
Is this regexp just used for matching or for categorising commits by scope? If it's just the former couldn't we use a simpler expression like ^fix:
There was a problem hiding this comment.
conventional commit format allows optional scopes such as feat(api):... and simplifying the regex won't support it. Simplifying it would also skip any merge commits, which I'm not sure is possible to happen right now, but better to be safe than sorry?
|
Isn't this PR "generate a changelog", I agree that it's better than nonexistence of changelog, but it's weird to call it "generate better changelog". 😄 |
yejseo01
force-pushed
the
better-changelog
branch
3 times, most recently
from
2b0226e to
34dc398
Compare
Signed-off-by: Yejin Seo <yejseo01@arm.com>
Signed-off-by: Yejin Seo <yejseo01@arm.com>
yejseo01
force-pushed
the
better-changelog
branch
from
34dc398 to
4a73a74
Compare
| changelog: | ||
| disable: true No newline at end of file | ||
| use: github | ||
| format: "{{ .Message }}{{ if .Logins }} ({{ .Logins | englishJoin }}){{ end }}" |
There was a problem hiding this comment.
Do we need to explicitly set format:?
| - '^(feat|fix|perf|security|breaking|build)(\\([^)]+\\))?(!)?: .*$' | ||
| - '^.*!:.*$' | ||
| - '^.*BREAKING CHANGE:.*$' |
There was a problem hiding this comment.
- I think we can drop "BREAKING CHANGE", because we mark them with
! - I don't think we need
build, but would benefit frochorewhich I believe is dependabot bumps - I'm not sure why we need first and second entry - the regex is hard to parse, can't we just:
include:
- "^(feat|fix|perf|security|chore)!?:"
5 participants
Changes