Skip to content

fix: let dark theme keyboard variables be overridden - #3127

Open
KevinSpek wants to merge 1 commit into
arnog:masterfrom
KevinSpek:fix-keyboard-theme-vars
Open

KevinSpek wants to merge 1 commit into
arnog:masterfrom
KevinSpek:fix-keyboard-theme-vars

Conversation

@KevinSpek

Copy link
Copy Markdown

Fixes #3049.

The dark theme blocks set --keyboard-toolbar-background-hover, --keycap-secondary-border and --keycap-secondary-border-bottom on .ML__keyboard, so a value set on :root was ignored. The private --_* variables already fall back to the same defaults, so these lines are removed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: CSS variable --keyboard-toolbar-background-hover is overridden by local scope on .ML__keyboard

1 participant