updateTableCells#429
Open
corrodis wants to merge 4 commits into
Open
Conversation
# Conflicts: # otsdaq/GatewaySupervisor/GatewaySupervisor.cc
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for updating specific table cells by UID/column via a new ConfigurationManagerRW::updateTableCells() workflow, motivated by tracker GUI needs. Also extends gateway status exchange to include active/selected config group metadata, and adds an option to suppress ARTDAQ multinode “printer syntax” compression when enumerating nodes.
Changes:
- Add
ConfigurationManagerRW::updateTableCells()API + implementation to apply per-UID cell edits and optionally set a version alias. - Extend
GatewaySupervisorremote status request/response to carry active context/config group (name+key) and resolved selected-config-alias group details. - Add
suppressMultiNodeoption toARTDAQTableBase::getARTDAQSystem()to emit concrete per-node records.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| otsdaq/TablePlugins/ARTDAQTableBase/ARTDAQTableBase.h | Adds suppressMultiNode parameter to getARTDAQSystem() declaration. |
| otsdaq/TablePlugins/ARTDAQTableBase/ARTDAQTableBase.cc | Implements suppressMultiNode behavior when building node records. |
| otsdaq/TableCore/TableView.h | Adds <map> include (supporting map-based APIs/usages). |
| otsdaq/GatewaySupervisor/GatewaySupervisor.h | Extends RemoteGatewayInfo with active/selected group name+key fields. |
| otsdaq/GatewaySupervisor/GatewaySupervisor.cc | Sends/parses additional remote status params and emits/parses new XML fields for group metadata. |
| otsdaq/ConfigurationInterface/ConfigurationManagerRW.h | Declares new updateTableCells() public API. |
| otsdaq/ConfigurationInterface/ConfigurationManagerRW.cc | Implements updateTableCells() end-to-end workflow and optional version-alias update. |
Comment on lines
+3194
to
+3200
| if(portForReverseLoginOverUDP || remoteGatewayApp.selected_config_alias != "") | ||
| requestString += "," + ipForReverseLoginOverUDP + "," + | ||
| std::to_string(portForReverseLoginOverUDP) + "," + | ||
| remoteGatewayApp.appInfo.name; | ||
| (portForReverseLoginOverUDP | ||
| ? std::to_string(portForReverseLoginOverUDP) | ||
| : "") + | ||
| "," + remoteGatewayApp.appInfo.name + "," + | ||
| remoteGatewayApp.selected_config_alias; |
Comment on lines
+4028
to
+4029
| if(params.size() >= 5) | ||
| requesterSelectedConfigAlias = params[4]; |
Comment on lines
+2611
to
+2613
| /// Loads the table at sourceVersion, creates a temporary view, applies cell updates | ||
| /// via TableView::updateCells(), saves a new persistent version, and optionally sets | ||
| /// a version alias on the new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding functionality to update individual cells in a table via updateTableCells. This was motivated by tracker GUI efforts.