You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The catch: the PR is low quality. The author flags it themselves — "entirely vibe coded and untested." Reading the code, it's worse than untested: the
ServerLoginPacketListenerImplMixin change deletes the redirect that installed Krypton's native ciphers and just calls vanilla setEncryptionKey(...). Net
effect: it loads without crashing, but Krypton's encryption optimization is silently bypassed — you fall back to Java's ciphers. (Krypton's
compression-natives and entity-tracker optimizations live in other mixins and would still work.) So this PR gives you "Krypton minus its signature
feature."
stupid pr. dont even have to test. krypton needs to be updated using additions from 26.2. anyone can change the version number needed and hope for the best.
stupid pr. dont even have to test. krypton needs to be updated using additions from 26.2. anyone can change the version number needed and hope for the best.
entirely vibe coded and untested
I am glad we are all on the same page!
Claude is not impressed:
The catch: the PR is low quality. The author flags it themselves — "entirely vibe coded and untested." Reading the code, it's worse than untested: the
ServerLoginPacketListenerImplMixin change deletes the redirect that installed Krypton's native ciphers and just calls vanilla setEncryptionKey(...). Net
effect: it loads without crashing, but Krypton's encryption optimization is silently bypassed — you fall back to Java's ciphers. (Krypton's
compression-natives and entity-tracker optimizations live in other mixins and would still work.) So this PR gives you "Krypton minus its signature
feature."
If anyone who earnestly wants to contribute to this repo (I just wanted to get a running version for a server I play on) wants to take anything from this PR it may be that @Shadow private boolean encrypted; (here) is not longer available in 26.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
entirely vibe coded and untested - using on my friends server