Skip to content

26.2#161

Closed
Trkyyy wants to merge 1 commit into
astei:masterfrom
Trkyyy:26.2
Closed

26.2#161
Trkyyy wants to merge 1 commit into
astei:masterfrom
Trkyyy:26.2

Conversation

@Trkyyy

@Trkyyy Trkyyy commented Jun 21, 2026

Copy link
Copy Markdown

entirely vibe coded and untested - using on my friends server

@Trkyyy Trkyyy marked this pull request as ready for review June 21, 2026 21:57
@spraot

spraot commented Jun 22, 2026

Copy link
Copy Markdown

Claude is not impressed:

The catch: the PR is low quality. The author flags it themselves — "entirely vibe coded and untested." Reading the code, it's worse than untested: the
ServerLoginPacketListenerImplMixin change deletes the redirect that installed Krypton's native ciphers and just calls vanilla setEncryptionKey(...). Net
effect: it loads without crashing, but Krypton's encryption optimization is silently bypassed — you fall back to Java's ciphers. (Krypton's
compression-natives and entity-tracker optimizations live in other mixins and would still work.) So this PR gives you "Krypton minus its signature
feature."

@y4shg

y4shg commented Jun 22, 2026

Copy link
Copy Markdown

stupid pr. dont even have to test. krypton needs to be updated using additions from 26.2. anyone can change the version number needed and hope for the best.

@Trkyyy

Trkyyy commented Jun 23, 2026

Copy link
Copy Markdown
Author

stupid pr. dont even have to test. krypton needs to be updated using additions from 26.2. anyone can change the version number needed and hope for the best.

entirely vibe coded and untested

I am glad we are all on the same page!

Claude is not impressed:

The catch: the PR is low quality. The author flags it themselves — "entirely vibe coded and untested." Reading the code, it's worse than untested: the
ServerLoginPacketListenerImplMixin change deletes the redirect that installed Krypton's native ciphers and just calls vanilla setEncryptionKey(...). Net
effect: it loads without crashing, but Krypton's encryption optimization is silently bypassed — you fall back to Java's ciphers. (Krypton's
compression-natives and entity-tracker optimizations live in other mixins and would still work.) So this PR gives you "Krypton minus its signature
feature."

If anyone who earnestly wants to contribute to this repo (I just wanted to get a running version for a server I play on) wants to take anything from this PR it may be that @Shadow private boolean encrypted; (here) is not longer available in 26.2

@Trkyyy Trkyyy closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants