fix: mark raw waker callbacks unsafe#84
Open
Sieger9303 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80.
Hi, thanks for maintaining this crate.
The RawWaker callbacks reconstruct an
Arc<Thread>from the raw pointer passed by the waker vtable. This is only valid when the pointer was originally produced byArc::<Thread>::into_rawand follows the ownership rules required by theRawWakerVTable.Previously these callback functions were plain safe functions, even though calling them directly with an arbitrary pointer could cause undefined behavior. This PR marks the callbacks as
unsafe fn. The actual runtime behavior is unchanged.