fix: add timeout to registryValidation to prevent indefinite hang#2112
Open
armorbreak001 wants to merge 4 commits intoasyncapi:masterfrom
Open
fix: add timeout to registryValidation to prevent indefinite hang#2112armorbreak001 wants to merge 4 commits intoasyncapi:masterfrom
armorbreak001 wants to merge 4 commits intoasyncapi:masterfrom
Conversation
- Add 5-second timeout using AbortController to prevent indefinite hang - Use HEAD request instead of GET for lighter validation - Clear timeout error message for unreachable registries - Fixes asyncapi#2027
armorbreak001
requested review from
AayushSaini101,
Amzani,
Shurtu-gal and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 5c580a9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Test URL parser validation (empty, invalid, http, https) - Test registry validation timeout behavior - Covers the fix in asyncapi#2027
- Remove unnecessary 'as string' cast on registryUrl (SonarQube issue) - Change 'error: any' to 'error: unknown' with instanceof guard
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2027
Problem
registryValidation()insrc/utils/generate/registry.tsusesfetch()with no timeout. When--registry-urlpoints to an unreachable host (e.g., blackholed IP), the CLI hangs indefinitely.Changes
AbortControllerwith 5-second timeout to the fetch callHEADinstead ofGETfor lighter weight registry validationAbortErrorand throw a clear timeout message: "Registry URL timed out after 5 seconds"Testing
npm run unit:test)