Fix contains many sort order if several sort arguments are passed#1300
Draft
PhilippGrashoff wants to merge 4 commits into
Draft
Fix contains many sort order if several sort arguments are passed#1300PhilippGrashoff wants to merge 4 commits into
PhilippGrashoff wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue might not be directly in ContainsMany itself but in the underlying persistence. The issue is:
if several sort arguments are passed to a ContainsMany Reference, they are applied in reverse order:
If
$someParent->ref('some_contains_many_reference')->setOrder(['field1' => 'ASC', 'field2' => 'ASC']is used, the actual sort is using the arguments in reverse order, so first sorts by field2, and then sorts by field1 for those entities with same field2 values.For now, I added a failing test to demonstrate the problem.