fix: resolve silent process exit when deploying 3+ organizations with discovery domains#1354
Open
ankita10119 wants to merge 5 commits intomasterfrom
Open
fix: resolve silent process exit when deploying 3+ organizations with discovery domains#1354ankita10119 wants to merge 5 commits intomasterfrom
ankita10119 wants to merge 5 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
- Coverage 80.10% 80.09% -0.01%
==========================================
Files 152 152
Lines 6212 6209 -3
Branches 1290 1290
==========================================
- Hits 4976 4973 -3
Misses 702 702
Partials 534 534 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tenant configuration includes 3 or more organizations that each have
discovery_domains, runninga0deploy importsilently exits mid-run without error. No discovery domains are created or updated, and the "Import Successful" message never appears.This affects both first-time deploys (create path) and subsequent deploys (update path). The process exits after the delete-warning phase, before any organization changes are applied.
🔧 Changes
client_grantssub-operations are handled in the same handler.dpop_signing_algnow gracefully omits the enum constraint when the SDK does not provide it.Backward Compatibility
No breaking changes. Behavior is identical for:
📚 References
🔬 Testing
📝 Checklist