Skip to content

fix: resolve silent process exit when deploying 3+ organizations with discovery domains#1354

Open
ankita10119 wants to merge 5 commits intomasterfrom
DXCDT-1584
Open

fix: resolve silent process exit when deploying 3+ organizations with discovery domains#1354
ankita10119 wants to merge 5 commits intomasterfrom
DXCDT-1584

Conversation

@ankita10119
Copy link
Copy Markdown
Contributor

When a tenant configuration includes 3 or more organizations that each have discovery_domains, running a0deploy import silently exits mid-run without error. No discovery domains are created or updated, and the "Import Successful" message never appears.

This affects both first-time deploys (create path) and subsequent deploys (update path). The process exits after the delete-warning phase, before any organization changes are applied.

🔧 Changes

  • organizations.ts: Discovery domain create/update/delete operations no longer route through the shared request pool. They now use Promise.all and direct API calls, consistent with how connections and client_grants sub-operations are handled in the same handler.
  • connections.ts: Fixed a crash at module load time when ConnectionDpopSigningAlgEnum is not present in the installed auth0 SDK version. The schema validation for dpop_signing_alg now gracefully omits the enum constraint when the SDK does not provide it.

Backward Compatibility

No breaking changes. Behavior is identical for:

  • Tenants with fewer than 3 organizations with discovery domains (the deadlock condition was never triggered).
  • Tenants without the Organization Discovery Domains feature enabled.
  • All other resource types — only the discovery domain sub-operations inside OrganizationsHandler are affected.

📚 References

🔬 Testing

  • Added a regression test that reproduces the deadlock condition directly
  • Tested with real tenant data as well

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ankita10119 ankita10119 requested a review from a team as a code owner April 7, 2026 07:09
@ankita10119 ankita10119 marked this pull request as draft April 7, 2026 07:09
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.09%. Comparing base (8fe0e28) to head (e5de6de).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
- Coverage   80.10%   80.09%   -0.01%     
==========================================
  Files         152      152              
  Lines        6212     6209       -3     
  Branches     1290     1290              
==========================================
- Hits         4976     4973       -3     
  Misses        702      702              
  Partials      534      534              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ankita10119 ankita10119 marked this pull request as ready for review April 10, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants