fix: exclude tests/ from built wheel#509
Merged
Merged
Conversation
The 3.6.0 wheel shipped a top-level `tests` package because setup.py
called `find_packages()` without exclusions. This collides with
downstream consumers that have their own `tests/` directory — most
notably Home Assistant Core, where hassfest rejects the dependency:
[ERROR] [REQUIREMENTS] Package pyisy has a forbidden top level
directory 'tests' in homeassistant
Excluding both `tests` and `tests.*` keeps the source tree shape but
keeps the wheel limited to the `pyisy` package.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 3.6.0 wheel ships a top-level
testspackage becausesetup.pycallsfind_packages()without exclusions. This breaks downstream consumers that have their owntests/directory — most notably Home Assistant Core, where hassfest fails:Adding
exclude=["tests", "tests.*"]keeps the source tree shape but limits the wheel to thepyisypackage.Verification
Follow-up
A 3.6.1 release is needed to unblock home-assistant/core#170136.
🤖 Generated with Claude Code