fix: resolve Windows path separator issue in zkit generated types - #79
Open
blastonyz wants to merge 1 commit into
Open
fix: resolve Windows path separator issue in zkit generated types#79blastonyz wants to merge 1 commit into
blastonyz wants to merge 1 commit into
Conversation
Normalize backslash import paths from @solarity/zktype on Windows and replace cmd & postinstall chaining with a cross-platform compile runner. Fixes: Error Cannot find module ..helpers during hardhat zkit verifiers. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running npm run compile on Windows fails with:
Error: Cannot find module '..helpers'
@solarity/zktype uses path.relative() for helper imports in generated .ts files. On Windows that produces backslashes (from "..\helpers"), which Node cannot resolve.
The existing postinstall script also used cmd & instead of sequential execution, breaking the compile chain on Windows.
Fix
scripts/fix-win-paths.js — normalize \ → / in generated-types/zkit/**/.ts after zkit make
scripts/run-compile.cjs — cross-platform sequential compile pipeline
scripts/zkit-require-alias.cjs + scripts/run-zkit-verifiers.cjs — fallback during verifier generation
package.json — compile, postinstall, and zkit: scripts
Testing
npm run compile on Windows 11 — 5 circuits compiled, 5 verifiers generated
macOS/Linux (expected no-op when paths already use /)
Related
Upstream: @solarity/zktype ZkitTSGenerator.ts → path.relative without POSIX normalization.