Allow custom providers in provider() type#74
Merged
onno-vos-dev merged 1 commit intoMay 24, 2024
Conversation
dw-kihara
commented
May 24, 2024
| ```erlang | ||
| #{ | ||
| provider_source => Provider :: atom(), | ||
| provider_source => Provider :: module(), |
Contributor
Author
There was a problem hiding this comment.
The module() type is effectively the same as the atom() type. However, I think this change clarifies that it represents a module name to the user.
Member
onno-vos-dev
approved these changes
May 24, 2024
Contributor
Author
Yes! I had trouble when writing that provider as a custom provider, so I made this pull request.
Agree, I also think the default providers should be listed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws_credentials allows users to add custom providers.
However, the
aws_credentials_provider:provider()type is currently limited to built-in module namescausing custom providers to be rejected by Dialyzer because their names are not listed in the
provider()type.Example:
This pull request adds the
module()type to theprovider()type, allowing custom providers to pass Dialyzer checks.Additionally, I made some minor changes related to custom providers.