Make sure the update callback timeout is valid - erlang:send_after cr…#90
Merged
onno-vos-dev merged 1 commit intoOct 21, 2025
Merged
Conversation
…ashes if provided a negative value
Member
|
Hi @wolfpack9377 very well aware of this issue 😅 And was going to write a similar fix as you proposed myself tomorrow so thank you for the PR 🙏 I'll roll out a release in the morning with this fix. Considering AWS appears to be recovering I'd like some sleep soon 💤😅 |
onno-vos-dev
approved these changes
Oct 21, 2025
Member
Contributor
Author
|
Awesome! Thank you for the quick turnaround! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ashes if provided a negative value
During the AWS outage today, the aws_credentials app ultimately was terminated because the supervisor reached the max restart intensity. The crash that was causing the restarts was:
,[{erlang,send_after,[-1000,<0.2314.0>,refresh_credentials],[{error_info,#{cause => time,module => erl_erts_errors}}]},{aws_credentials,setup_callback,1,Unfortunately, the actual value being returned for the expiration during this period was not in the stack trace. I'm sure this is an exceptional case but if the app were to remain running, it could, in theory recover once the service disruption is over.