Skip to content

Parameter YAML Extraction from SchematicGraph#210

Open
abuzali-cqc wants to merge 1 commit into
aws-cqc:mainfrom
abuzali-cqc:abuzali/parameter-extraction
Open

Parameter YAML Extraction from SchematicGraph#210
abuzali-cqc wants to merge 1 commit into
aws-cqc:mainfrom
abuzali-cqc:abuzali/parameter-extraction

Conversation

@abuzali-cqc

Copy link
Copy Markdown

No description provided.

@abuzali-cqc abuzali-cqc changed the title Paramater YAML Extraction from SchematicGraph Parameter YAML Extraction from SchematicGraph Apr 24, 2026

@ad-cqc ad-cqc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, in my PR, I use YAML.jl as week dependency. It may worth to consider to move deserialization functionality to the corresponding package extension.

Comment thread src/schematics/parameter_extraction.jl
Comment thread src/schematics/parameter_extraction.jl
Comment thread src/schematics/parameter_extraction.jl
Comment thread src/schematics/parameter_extraction.jl
Comment thread src/schematics/parameter_extraction.jl
@gpeairs

gpeairs commented Apr 28, 2026

Copy link
Copy Markdown
Member

Hi Alex, thanks for getting this rolling! What would you think of coordinating with #204 so that extract_parameters can return a ParameterSet and delegate YAML I/O entirely to Art's extension? Are there any incompatible requirements between the two use cases?

Comment thread Project.toml
@abuzali-cqc

Copy link
Copy Markdown
Author

@gpeairs @ad-cqc I agree with Greg's point that it makes more sense to have the extraction return a ParameterSet and leave the YAML I/O entirely to to the ParameterSet methods, so I'll likely create a new PR building off of Art's branch. I agree we should use YAML.jl wherever possible, though we might need to add some extra functionality: as far as I can tell the package doesn't support writing anchors and references (only reading them), which is important for specifying component defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants