Parameter YAML Extraction from SchematicGraph#210
Conversation
ad-cqc
left a comment
There was a problem hiding this comment.
BTW, in my PR, I use YAML.jl as week dependency. It may worth to consider to move deserialization functionality to the corresponding package extension.
|
Hi Alex, thanks for getting this rolling! What would you think of coordinating with #204 so that |
|
@gpeairs @ad-cqc I agree with Greg's point that it makes more sense to have the extraction return a ParameterSet and leave the YAML I/O entirely to to the ParameterSet methods, so I'll likely create a new PR building off of Art's branch. I agree we should use YAML.jl wherever possible, though we might need to add some extra functionality: as far as I can tell the package doesn't support writing anchors and references (only reading them), which is important for specifying component defaults. |
No description provided.