Skip to content

Address cleanup issues for #247#254

Open
gpeairs wants to merge 6 commits into
mainfrom
gp/issue-247-cleanups
Open

Address cleanup issues for #247#254
gpeairs wants to merge 6 commits into
mainfrom
gp/issue-247-cleanups

Conversation

@gpeairs

@gpeairs gpeairs commented Jul 10, 2026

Copy link
Copy Markdown
Member

This addresses the mechanical cleanup items in #247:

  • Offset segment on CompoundStyle is a hard error
  • Unrenderable segment fallback shows a clear error
  • Use Set/Dict for corner index lookups in round_to_curvilinearpolygon
  • Deduplicate some pathtopolys code
  • Test for default absolute rounding for dimensionless geometry

@gpeairs gpeairs requested a review from laylagi July 10, 2026 11:55
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/curvilinear.jl 95.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant