Fix rendering of full 360°-multiple turns (issue #252)#256
Open
gpeairs wants to merge 1 commit into
Open
Conversation
Turns sweeping an exact multiple of 360° have coincident endpoints, which the pathtopolys degenerate-point checks and the CurvilinearPolygon constructor's duplicate-point elimination silently collapsed to empty geometry (degenerate 2-point polygons in GDS, zero-area surfaces in SolidModel). Full turns are now split into two half turns during path polygonization, rendering as two polygons per surface — exact in both backends. Closed segments reaching the degenerate corner-point checks now fail loudly with an ArgumentError instead of silently dropping a curve. Also documents the difference2d + RelativeRounded(0.5) ring recipe.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #252. Turns sweeping an exact multiple of 360° have coincident endpoints, which the pathtopolys degenerate-point checks and the CurvilinearPolygon constructor's duplicate-point elimination silently collapsed to empty geometry (degenerate 2-point polygons in GDS, zero-area surfaces in SolidModel). Full turns are now split into two half turns during path polygonization, rendering as two polygons per surface — exact in both backends. Closed segments reaching the degenerate corner-point checks now fail loudly with an ArgumentError instead of silently dropping a curve.
Also documents the difference2d + RelativeRounded(0.5) ring recipe.