chore: counts of non hotswappable resources#1373
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
=======================================
Coverage 88.31% 88.31%
=======================================
Files 74 74
Lines 10430 10443 +13
Branches 1427 1434 +7
=======================================
+ Hits 9211 9223 +12
- Misses 1191 1192 +1
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
left a comment
There was a problem hiding this comment.
"AWS::Some::Resource": 2,
"AWS::Other::Resource": 1,
This list of counters goes into a huge grab bag. So just a resource type by itself is not going to be meaningful. Let's name it something like
hotswapfallback:AWS::Other::Resource
But also don't do that literally! I'm pretty sure we already emit counters with resource identifiers in there somewhere. I forget where, but I'm sure you can find it. Probably something about error tracking. Don't invent a new format, just follow what the other location is doing.
And also: I'm pretty sure the top-level property that is causing the fallback should be in there as well.
It is error tracking, that does |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Adds counts for resource types that are not hotswappable that were attempted to be hotswapped.
We want to track this as a part of our initiative to improve the speed of hotswap deployments since having non hotswappable resources in a hotswap deployment with fallback slows down the hotswap deployment.
Payload would look like this:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license