Skip to content

chore: disallow relative imports#8403

Open
bchampp wants to merge 8 commits intoaws:developfrom
bchampp:tmp-disallow-relative-imports
Open

chore: disallow relative imports#8403
bchampp wants to merge 8 commits intoaws:developfrom
bchampp:tmp-disallow-relative-imports

Conversation

@bchampp
Copy link
Copy Markdown
Member

@bchampp bchampp commented Nov 5, 2025

Which issue(s) does this change fix?

Why is this change necessary?

Updating the linting configuration in SAM CLI to disallow relative imports.

How does it address the issue?

Adding updated rules in the linting configuration in pyproject.toml to disallow relative imports. Updating all instances of relative imports to absolute for make pr to pass.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bchampp bchampp requested a review from a team as a code owner November 5, 2025 04:00
@github-actions github-actions bot added area/local/start-api sam local start-api command area/init sam init area/local/invoke sam local invoke command area/pipeline area/local/start-invoke pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 5, 2025
@bchampp bchampp marked this pull request as draft December 3, 2025 06:46
@bchampp bchampp force-pushed the tmp-disallow-relative-imports branch 2 times, most recently from d4f4d3e to 5224e68 Compare January 30, 2026 18:37
@bchampp bchampp force-pushed the tmp-disallow-relative-imports branch from 5224e68 to da61683 Compare January 30, 2026 18:42
@bchampp bchampp marked this pull request as ready for review January 30, 2026 19:02
vicheey
vicheey previously approved these changes Jan 30, 2026
Copy link
Copy Markdown
Contributor

@vicheey vicheey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@roger-zhangg
Copy link
Copy Markdown
Member

Seems there's issue on installer test, could you help to take another look

@vicheey vicheey added need-customer-response Waiting for customer response and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Mar 26, 2026
@reedham-aws reedham-aws removed the need-customer-response Waiting for customer response label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants