fix: improve misleading authorizer log message for non-Lambda authorizers#8912
Open
roger-zhangg wants to merge 1 commit intodevelopfrom
Open
fix: improve misleading authorizer log message for non-Lambda authorizers#8912roger-zhangg wants to merge 1 commit intodevelopfrom
roger-zhangg wants to merge 1 commit intodevelopfrom
Conversation
…zers When an HttpApi uses AWS_IAM as DefaultAuthorizer, the log incorrectly shows 'authorizer None is unsupported or not found'. This fixes the log to use the actual authorizer name and differentiates known non-Lambda authorizers from truly missing ones. Fixes #7750
reedham-aws
reviewed
Apr 10, 2026
|
|
||
| class ApiCollector: | ||
| # Authorizer types that are valid but not Lambda-based, so cannot be emulated locally | ||
| _NON_LAMBDA_AUTHORIZERS = {"AWS_IAM", "NONE"} |
Contributor
There was a problem hiding this comment.
Would Cognito authorization need to be included here? I'm not sure if we accept that or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#7750
Why is this change necessary?
When using
sam local start-apiwith anHttpApithat hasDefaultAuthorizer: AWS_IAMandEnableIamAuthorizer: true, the log message is misleading:Two bugs:
route.authorizer_name(None) instead ofauthorizer_name_lookup(AWS_IAM)AWS_IAM) and a truly missing/invalid authorizerHow does it address the issue?
_NON_LAMBDA_AUTHORIZERSset ({"AWS_IAM", "NONE"}) toApiCollectorINFOmessage clarifying it is not supported for local emulation:WARNING:NoneWhat side effects does this change have?
INFOtoWARNING, which is more appropriate since it likely indicates a template issue.Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.