Skip to content

feat: add ability to pass docker build params in template#8913

Draft
reedham-aws wants to merge 1 commit intoaws:developfrom
reedham-aws:docker-args
Draft

feat: add ability to pass docker build params in template#8913
reedham-aws wants to merge 1 commit intoaws:developfrom
reedham-aws:docker-args

Conversation

@reedham-aws
Copy link
Copy Markdown
Contributor

Which issue(s) does this change fix?

#8656

Why is this change necessary?

It had not been previously possible to pass in standard Docker arguments to the CLI build. While this isn't a big issue, it's a nice quality of life feature to add.

How does it address the issue?

Adds the ability to read extra parameters from the metadata of a SAM template, similar to how we already read build args that go into the Dockerfile. These parameters are then appended to the Docker/Finch CLI subprocess call.

What side effects does this change have?

Should have none because this is opt-in. Integration tests should confirm this.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke pr/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant