Skip to content

move interceptor validation after error parsing#3788

Open
sbiscigl wants to merge 1 commit intomainfrom
get-object-retry
Open

move interceptor validation after error parsing#3788
sbiscigl wants to merge 1 commit intomainfrom
get-object-retry

Conversation

@sbiscigl
Copy link
Copy Markdown
Collaborator

@sbiscigl sbiscigl commented Apr 6, 2026

Description of changes:

Moves the application of interceptors to after error parsing. This notable impacts S3GetObject which would return a checksum mismatch on a timeout, however should return the timeout error as checksum mismatch is non-retryable, and the timeout is the correct error to retry on.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review April 6, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants