#6949 Fix Netty streaming completion guard#7114
Open
arnabnandy7 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #6949.
NettyNioAsyncHttpClientcould suppress a channel-inactive fallback error whenSTREAMING_COMPLETE_KEYwas true butRESPONSE_COMPLETE_KEYwas not yet true. ForAsyncResponseTransformer.toPublisher(), observing the final HTTP content does not necessarily mean the caller-visible response publisher has received a terminal signal, so this could leave subscribers waiting indefinitely.Modifications
Changed
ResponseHandler.notifyIfResponseNotCompleted()to treat onlyRESPONSE_COMPLETE_KEY=trueas sufficient proof that the response has completed.Added a regression test covering the problematic state where streaming is marked complete, response finalization has not happened, and the channel becomes inactive. The test verifies that an
IOExceptionis surfaced, the execute future completes exceptionally, and the channel is released.Added a changelog entry for the Netty NIO Async HTTP Client bug fix.
Testing
Ran:
Result: passed, 6 tests.
Also ran:
This failed before reaching the Netty module in
core/annotationsduring SpotBugs.Also ran:
This failed due to unrelated local runtime/tooling issues: WireMock certificate generation was unsupported on this runtime, and JaCoCo reported
Unsupported class file major version 70.Ran:
Result: passed.
Screenshots (if appropriate)
N/A
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License