-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Lambda versioning and alias support #2173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -343,6 +343,12 @@ def reserved_concurrency(self) -> int: | |
| varies_per_chalice_stage=True, | ||
| varies_per_function=True) | ||
|
|
||
| @property | ||
| def lambda_alias(self) -> Optional[str]: | ||
| return self._chain_lookup('lambda_alias', | ||
| varies_per_chalice_stage=True, | ||
| varies_per_function=True) | ||
|
|
||
|
Comment on lines
+346
to
+351
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 -> A validation function similar to the ones in validate.py would work well here. |
||
| def scope(self, chalice_stage: str, function_name: str) -> Config: | ||
| # Used to create a new config object that's scoped to a different | ||
| # stage and/or function. This creates a completely separate copy. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
ResourceConflictExceptionis caught,_latest_published_function_versionwould return the version form the previous deploy. Instead of using the latest published version when there's a conflict, is it possible to add a delay, similar how its done here?