fix(examples): add missing json/re imports in DPO notebook pretty_print#6058
Merged
aviruthen merged 1 commit intoJul 20, 2026
Merged
Conversation
dpo_trainer_example_notebook_v3_prod defines a pretty_print helper that calls json.dumps() and re.findall(), but the cell imports neither json nor re -- they are only imported in a later cell. So the first pretty_print(training_job) call fails with NameError: name 'json' is not defined. Import json and re at the top of the helper cell so it runs standalone.
Hannah14295
temporarily deployed
to
manual-approval
July 18, 2026 23:38 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
aviruthen
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dpo_trainer_example_notebook_v3_prod defines a pretty_print helper that calls json.dumps() and re.findall(), but the cell imports neither json nor re -- they are only imported in a later cell. So the first pretty_print(training_job) call fails with NameError: name 'json' is not defined.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.