[DO NOT MERGE] test: verify Codecov after --cov=sagemaker CR deploy#6066
Open
jam-jee wants to merge 1 commit into
Open
[DO NOT MERGE] test: verify Codecov after --cov=sagemaker CR deploy#6066jam-jee wants to merge 1 commit into
jam-jee wants to merge 1 commit into
Conversation
No-op comment in all 4 submodule __init__.py files so every unit-test job runs and uploads coverage. Purpose: confirm whether the just-deployed buildspec CR (--cov=. -> --cov=sagemaker) now produces product-only coverage (~71%, test files excluded) instead of the old test-inflated ~90%. Same-repo branch, cut from current master. Verification only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-verification after the CI buildspec CR (
--cov=.→--cov=sagemaker) was deployed to prod. No-op comment in all 4 submodule__init__.pyfiles so every unit-test job runs and uploads coverage.Goal
Confirm the deployed CR produces product-only coverage (~71%, test files excluded via the merged
codecov.ymlignore:) instead of the old test-inflated ~90%.Known caveats (may still block a clean PR result)
after_n_builds: 4is still on master (fix fix: remove codecov after_n_builds so single-submodule PRs report coverage #6056 not yet merged). Uses 4 submodules to try to satisfy the count.branch=empty,pr=false, and no per-submodule-Fflag, which caused the earlier 4-module run ([DO NOT MERGE] test: verify Codecov across all 4 submodules #6057) to collapse tosessions=1, 3 files, 37%and post no PR status. If the deploy did not also fix the uploader, coverage may still not attach to this PR — in that case check the commit report on codecov.io directly.Will be closed without merging once we read the result.