Explicitly configure wix properties not defaulted from metadata#1798
Open
pnehrer wants to merge 2 commits intoaxodotdev:mainfrom
Open
Explicitly configure wix properties not defaulted from metadata#1798pnehrer wants to merge 2 commits intoaxodotdev:mainfrom
pnehrer wants to merge 2 commits intoaxodotdev:mainfrom
Conversation
Contributor
|
Sorry for the late review. Makes sense to me - I'll look into adding this to the tests so we can be sure it works. |
Contributor
|
In testing now, we are bringing these values in from Cargo.toml. For example, in the axolotlsay test, we're getting the axolotlsay package's description and URL. Is your goal here to override those values with something else? |
Contributor
Author
|
Yes, we were hoping to be able to override these explicitly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In spite of what the documentation claims,
cargo wixdoesn't use certain properties defined in the package's[package.metadata.wix]section:This PR explicitly reads these properties from metadata and populates builder with any values it finds.