Draft
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
The aya-xdp-dispatcher-ebpf build.rs unconditionally panics when bpf-linker is not in PATH, causing CI failures in lint and build-test-aya jobs that don't install bpf-linker. Changes: - ebpf/aya-xdp-dispatcher-ebpf/build.rs: conditional bpf-linker check - aya-xdp-dispatcher/build.rs: stub file when not building eBPF - ebpf/aya-xdp-dispatcher-ebpf/src/main.rs: use ebpf-panic crate - ebpf/aya-xdp-dispatcher-ebpf/src/prog.rs: remove duplicate panic handler - ci.yml: exclude aya-xdp-dispatcher-ebpf from host jobs, include in eBPF jobs - xtask/src/clippy.rs: add to eBPF packages list - aya-xdp-dispatcher/src/lib.rs: fix wildcard import and redundant match
Stable rustc cannot infer the type parameter on Ok(build_integration_bpf) without an explicit `: bool` annotation on the parse result. Also fixes rustfmt formatting.
- aya-xdp-dispatcher/build.rs: add explicit -> anyhow::Result<bool> return type on closure to resolve E0282/E0283 type inference errors - aya-obj/src/btf/btf.rs: collapse if into match guard to satisfy nightly clippy collapsible_match lint
Use map_or instead of map().unwrap_or() on Result value.
- Use assert! instead of if { panic! } (manual_assert)
- Use drop() instead of let _ = (let_underscore_must_use, let_underscore_drop)
- Use const fn matching pass.rs and two_progs.rs patterns - Use // comments instead of /// doc comments for binary entry points
The `cargo xtask public-api` lint step requires these files to track the public API surface of all publishable crates. Generated via `cargo xtask public-api --bless`.
Fix CI for xdp-dispatcher crates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation for #62
Note: This protocol is not compatible with libxdp
This change is