Closes #5744: Adding default metatag tokens to az_course - #5745
Closes #5744: Adding default metatag tokens to az_course#5745camikazegreen wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
I wasn't sure whether to put this in the install folder or as optional config since I do not want az_seo to depend on az_course, but I followed the existing pattern from Event, News and Person.
There was a problem hiding this comment.
Error message
Unable to install Quickstart Course, core.entity_form_display.node.az_course.default already exists in active configuration.
What is our standard pattern when we want to have two modules both be optional, but interact successfully in the cases where they are both installed?
There was a problem hiding this comment.
Maybe core.entity_form_display.node.az_course.default.yml should be in config/optional as well instead of config/quickstart?
There was a problem hiding this comment.
That works for it to successfully install, add the field to the course content type and display correctly.
What it does not do is add the metatag field to the node edit form for the ability to edit/override. Maybe that's ok?
There was a problem hiding this comment.
I don't think we currently have any other existing patterns where an optional module overrides the configuration of an optional module without depending on it.
This same issue probably affects publications also, which should properly have metatags.
Some options:
- Expand our quickstart config provider to have a notion of selective overrides to optional modules?
- Programmatic hook to add the configuration change via code (not necessarily great as it wouldn't allow for distribution updates of that)
- A recipe that adds metatag fields to content types that lack it?
- make courses depend on az_seo
There was a problem hiding this comment.
At the Wednesday meeting on 7/15 we decided to just make courses depend on az_seo.
3f05e49 to
b07c10e
Compare
|
I recreated this branch from a clean main to resolve some branch history and CI issues encountered while rebasing. The replacement PR is #5785 . Closing this one in favor of the clean history. |
Description
Closes #5744 by adding default SEO metatag support for Course content.
This change:
field_az_metatagattachment to the Course content type.az_seois installed.Related issues
Closes #5744
How to test
az_courseandaz_seoenabled.<title>uses the Course title.<meta name="description">uses the Course description.Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Checklist