Skip to content

Closes #5853: Update experimental AZ Navbar Fullscreen for Arizona Bootstrap v5.1.7 - #5855

Merged
joeparsons merged 4 commits into
mainfrom
issue/5853
Jul 30, 2026
Merged

Closes #5853: Update experimental AZ Navbar Fullscreen for Arizona Bootstrap v5.1.7#5855
joeparsons merged 4 commits into
mainfrom
issue/5853

Conversation

@bberndt-uaz

@bberndt-uaz bberndt-uaz commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Description

  • AZ Navbar Fullscreen template: Updates the mobile search button in the navbar to change the navbar-toggler-search class to az-search-toggle, the search-icon class to az-search-icon, and the aria-label from "Search the site" to "Search site".
  • AZ Navbar Fullscreen template: Updates the initial HTML for the primary menu page on mobile. These changes are necessary due to updates made to the AZ Navbar Fullscreen JS in how the initial menu page is determined.
  • Search block form input template: Updates the search-icon class to az-search-icon.

Related issues

How to test

https://pr5855-jx2jwjzwxewxs9cs1zvczn7zvwhrbywe.tugboatqa.com

  1. Enable and set up AZ Navbar Fullscreen (already completed in Tugboat).
  2. Simulating a mobile device, confirm the changes to the search button in the AZ Navbar Fullscreen navbar.
  3. Confirm the updated az-search-icon class for the search button accompanying input fields.
  4. Confirm the general appearance and functionality of AZ Navbar Fullscreen on both desktop and mobile.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@bberndt-uaz bberndt-uaz self-assigned this Jul 29, 2026
@bberndt-uaz
bberndt-uaz requested review from a team as code owners July 29, 2026 22:38
@bberndt-uaz bberndt-uaz added the high priority Must get done for this milestone label Jul 29, 2026
@bberndt-uaz bberndt-uaz linked an issue Jul 29, 2026 that may be closed by this pull request
3 tasks
@bberndt-uaz bberndt-uaz moved this from Todo to Needs review in 3.4.7 bug-fix patch release Jul 29, 2026
@bberndt-uaz bberndt-uaz moved this from Todo to Needs review in 3.5.0-alpha3 pre-release Jul 29, 2026

@djcelaya djcelaya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @bberndt-uaz! I am seeing a possible regression with the mobile menu. I am trying to figure out what is happening but right now I've been seeing the wrong menu display given the active page and also the primary links seems to gain active when one of their children is actually active.

Are you seeing anything weird on your end? I am investigating more.

@djcelaya

Copy link
Copy Markdown
Contributor

Hi, @bberndt-uaz! I am seeing a possible regression with the mobile menu. I am trying to figure out what is happening but right now I've been seeing the wrong menu display given the active page and also the primary links seems to gain active when one of their children is actually active.

Are you seeing anything weird on your end? I am investigating more.

I enabled AZ Navbar Fullscreen on the Tugboat site. To reproduce, go here: https://pr5855-jx2jwjzwxewxs9cs1zvczn7zvwhrbywe.tugboatqa.com/calendar and then open up the modal menu.

Screenshot 2026-07-29 at 4 23 03 PM Screenshot 2026-07-29 at 4 23 20 PM

@djcelaya

Copy link
Copy Markdown
Contributor

Curiously, links at the third level appear to still bring up the correct menu.

@bberndt-uaz

Copy link
Copy Markdown
Contributor Author

Good catch: it seems to be a problem with the initial HTML for the primary menu. I'll take a look.

@bberndt-uaz

bberndt-uaz commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

I think I have fixed it, but I'll review it further tomorrow. I believe that part of the template needed further updates after we added buttons to the mobile primary menu pages. Thanks again for catching that!

Edit: Oh sorry, didn't see your branch. I think we're on the same page!

@djcelaya

djcelaya commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Sounds good. Thanks for looking into that!!

No problem: I will close it soon in favor of your fixes on this PR.

Comment thread themes/custom/az_barrio/components/az-navbar-fullscreen/az-navbar-fullscreen.twig Outdated
Co-authored-by: David Celaya-Gonzalez <2702851+djcelaya@users.noreply.github.com>
@github-project-automation github-project-automation Bot moved this from Needs review to Ready to merge in 3.5.0-alpha3 pre-release Jul 30, 2026
@github-project-automation github-project-automation Bot moved this from Needs review to Ready to merge in 3.4.7 bug-fix patch release Jul 30, 2026
@joeparsons
joeparsons merged commit 92c259e into main Jul 30, 2026
33 checks passed
@joeparsons
joeparsons deleted the issue/5853 branch July 30, 2026 20:50
@github-project-automation github-project-automation Bot moved this from Ready to merge to Done in 3.5.0-alpha3 pre-release Jul 30, 2026
@github-project-automation github-project-automation Bot moved this from Ready to merge to Done in 3.4.7 bug-fix patch release Jul 30, 2026
bberndt-uaz added a commit that referenced this pull request Jul 30, 2026
…otstrap v5.1.7 (#5855)

Co-authored-by: David Celaya-Gonzalez <2702851+djcelaya@users.noreply.github.com>
(cherry picked from commit 92c259e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

high priority Must get done for this milestone

Projects

Development

Successfully merging this pull request may close these issues.

Update experimental AZ Navbar Fullscreen for Arizona Bootstrap v5.1.7

4 participants