Skip to content

refactor: Cache the Config Value #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nyeriah merged 4 commits into from
Apr 12, 2026
Merged

refactor: Cache the Config Value #33

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15def80
Cache the config
Tereneckla Jul 25, 2025
31b0e74
use cached config
Tereneckla Jul 25, 2025
9801b12
more
Tereneckla Oct 15, 2025
7adf784
Update src/MyPlayer.cpp
Tereneckla Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 41 additions & 5 deletions src/MyPlayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,67 @@
* Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license: https://github.com/azerothcore/azerothcore-wotlk/blob/master/LICENSE-AGPL3
*/

#include "ScriptMgr.h"
#include "Player.h"
#include "Config.h"
#include "Chat.h"
#include "ConfigValueCache.h"
#include "Player.h"
#include "ScriptMgr.h"

enum MyPlayerAcoreString
{
HELLO_WORLD = 35410
};

enum class MyConfig
{
ENABLED,

NUM_CONFIGS,
};

class MyConfigData : public ConfigValueCache<MyConfig>
{
public:
MyConfigData() : ConfigValueCache(MyConfig::NUM_CONFIGS) { };

void BuildConfigCache() override
{
SetConfigValue<bool>(MyConfig::ENABLED, "MyModule.Enable", true);
}
};

static MyConfigData myConfigData;

// Add player scripts
class MyPlayer : public PlayerScript
{
public:
MyPlayer() : PlayerScript("MyPlayer") { }
MyPlayer() : PlayerScript("MyPlayer", {
PLAYERHOOK_ON_LOGIN
}) { }

void OnPlayerLogin(Player* player) override
{
if (sConfigMgr->GetOption<bool>("MyModule.Enable", false))
if (myConfigData.GetConfigValue<bool>(MyConfig::ENABLED))
ChatHandler(player->GetSession()).PSendSysMessage(HELLO_WORLD);
}
};

class MyWorldScript : public WorldScript
{
public:
MyWorldScript() : WorldScript("MyWorldScript", {
Comment thread
Tereneckla marked this conversation as resolved.
Outdated
WORLDHOOK_ON_BEFORE_CONFIG_LOAD
}) { }

void OnBeforeConfigLoad(bool reload) override
{
myConfigData.Initialize(reload);
}
};

// Add all scripts in one
void AddMyPlayerScripts()
{
new MyPlayer();
new MyWorldScript();
}