Skip to content

fix: align tombstone key validation - #4

Merged
b2m9 merged 1 commit into
mainfrom
fix/tombstone-key-validation
Jul 31, 2026
Merged

fix: align tombstone key validation#4
b2m9 merged 1 commit into
mainfrom
fix/tombstone-key-validation

Conversation

@b2m9

@b2m9 b2m9 commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • validate tombstones against enumerable own string and symbol keys
  • ignore unsafe delta keys consistently with ordinary object folds
  • add regressions for symbol-bearing and unsafe-key tombstones

Testing

  • npm run check

Summary by cubic

Aligns tombstone key validation with merge behavior so we only check enumerable own keys and consistently ignore unsafe keys. Prevents false rejections when symbol-key patch data is present.

  • Bug Fixes
    • Validate tombstones using enumerableOwnKeys (includes symbol keys, excludes inherited).
    • Ignore UNSAFE_KEYS on tombstones, matching ordinary delta object handling.
    • Add tests for symbol-keyed fields and unsafe keys on tombstones.

Written for commit 1861cb8. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@b2m9
b2m9 merged commit b9a2c53 into main Jul 31, 2026
4 checks passed
@b2m9
b2m9 deleted the fix/tombstone-key-validation branch July 31, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant