ci: test Node floor and newest only - #5
Merged
Conversation
The matrix ran the engines floor, the active LTS, and the current release. The middle entry is bracketed by the other two: it can only fail if one of them also fails, so it bought a third of the CI cost for no new signal. Keep the floor, which is the only leg that verifies the `>=22` claim in package.json, and the newest, which catches toolchain drift. Record the policy in a comment so the pair reads as a rule rather than a stale list. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the Node version matrix from
[22, 24, 26]to[22, 26].Why
The three legs were the engines floor, the active LTS, and the current release. The middle entry is bracketed by the other two — it can only fail if one of them also fails — so it cost a third of CI for no new signal.
The two that remain do distinct jobs:
engines: ">=22"floor. It is the only leg that can catch code using an API newer than the version the package claims to support.Maintenance policy
The comment in the workflow records the rule so the pair reads as a policy rather than a list that someone forgot to extend:
enginesinpackage.jsonmoves. It is not driven by Node's EOL calendar — if the claim stays>=22past 22's EOL, the leg stays too, because the leg is what makes the claim true.That is roughly one line edit a year, and the list never grows.
Risk
Low for this package.
src/imports zero Node built-ins, andtsconfig.jsonsets"lib": ["ES2022"], so too-new language APIs already fail at typecheck time on any Node. The matrix is a backstop and a signal to consumers, not the primary guard.🤖 Generated with Claude Code
Summary by cubic
CI now tests only the Node engines floor and the newest LTS to cut redundant runs without losing signal. Matrix reduced from [22, 24, 26] to [22, 26], with a workflow comment documenting the update policy.
Written for commit db656e3. Summary will update on new commits.