fix(review): use canonical GPT-5.6 Sol model ID#1076
Open
rNoz wants to merge 1 commit into
Open
Conversation
Migrate saved review, tour, and guide Codex preferences from gpt-5.6 to gpt-5.6-sol so existing selections continue to launch.
Author
|
Author of reported bug #1070 (comment) has confirmed this PR fixes the issue. |
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the Codex catalog's canonical
gpt-5.6-solidentifier for GPT-5.6 Sol and migrate persistedgpt-5.6settings so existing users do not keep sending the stale model ID.Fixes #1070
Root cause
The review settings catalog exposed GPT-5.6 Sol with the model value
gpt-5.6, while OpenAI Codex 0.144.4 publishes the model asgpt-5.6-solin its authoritativemodels.json. AgentsTab feeds that catalog value into persisted Codex settings, so both new selections and previously saved review, tour, or guide selections could retain the stale identifier.Changes
gpt-5.6-solwith the display labelGPT-5.6 Sol.migrateCodexSectionto migrate stale review, tour, and guide model selections.gpt-5.6togpt-5.6-sol.This does not change provider defaults, reasoning options, fast-mode behavior, or settings for unrelated models.
Validation
bun test packages/ui/components/AgentsTab.test.ts packages/ui/hooks/useAgentSettings.test.ts: 13 passed, 0 failed, 16 assertions.bun run typecheckwith TypeScript 5.9.3 available onPATH: passed.bun test: 2,132 passed, 99 skipped, 0 failed.bun run --cwd apps/review build: passed.bun run build:hook: passed after the review build.Manual testing gap
A live launch against Codex 0.144.4 was not run because the locally installed Codex CLI was older during validation. The canonical identifier was verified against Codex 0.144.4
models.json, and the focused tests cover catalog selection plus persisted migration behavior.Please, let me know if you want that I do some further E2E test/proof. Otherwise, ready.