Spec dispute documents #571
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,3 +35,41 @@ | |
| raise 'Unable to get a dispute in 3 minutes' if count == 0 | ||
| @client.add_hydrate(:dispute_id, @dispute_id) | ||
| end | ||
|
|
||
| Given(/^I have a customer who will dispute any charge and I intend to disprove$/) do | ||
| step "I have created a customer" | ||
| @client.post('/cards', | ||
| { | ||
| number: "6500000000000003", | ||
| expiration_month: 12, | ||
| expiration_year: 3000, | ||
| cvv: "123", | ||
| customer: @customer_id | ||
| } | ||
| ) | ||
| @dispute_card_id = @client['cards']['id'] | ||
| @client.add_hydrate(:dispute_card_id, @dispute_card_id) | ||
| end | ||
|
|
||
| Given(/^I have debited a card that will initiate a dispute with submitted documents$/) do | ||
| step "I have a customer who will dispute any charge and I intend to disprove" | ||
| @client.post("/cards/#{@dispute_card_id}/debits", { | ||
| 'amount' => 99999 | ||
| }) | ||
| @disputed_debit_id = @client['debits']['id'] | ||
| @client.add_hydrate(:disputed_debit_id, @disputed_debit_id) | ||
| end | ||
|
|
||
| Given(/^I have a dispute with submitted documents$/) do | ||
| step 'I have debited a card that will initiate a dispute with submitted documents' | ||
| @dispute_id = nil | ||
| count = 60 | ||
| while @dispute_id.nil? and count > 0 | ||
|
Contributor
There was a problem hiding this comment. @remear what do you think about removing this polling shit and tasking someone to fix the dispute latency? this is a cancer across all our specs.
Contributor
Author
There was a problem hiding this comment.
Completely agree. This polling stuff horrible. |
||
| count -= 1 | ||
| @client.get("/debits/#{@disputed_debit_id}") | ||
| @dispute_id = @client['debits']['links']['dispute'] | ||
| sleep 3 | ||
| end | ||
| raise 'Unable to get a dispute in 3 minutes' if count == 0 | ||
| @client.add_hydrate(:dispute_id, @dispute_id) | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-04/schema#", | ||
| "type": "object", | ||
| "properties": { | ||
| "id": { | ||
| "type": "string", | ||
| "pattern": "DD[a-zA-Z0-9]{16,32}" | ||
| }, | ||
| "href": { | ||
| "type": "string", | ||
| "format": "uri" | ||
| }, | ||
| "created_at": { | ||
| "type": "string", | ||
| "format": "date-time" | ||
| }, | ||
| "updated_at": { | ||
| "type": "string", | ||
| "format": "date-time" | ||
| }, | ||
| "url": { | ||
| "description": "The url where the file may be accessed", | ||
| "type": "string", | ||
| "format": "uri" | ||
| }, | ||
| "file_type": { | ||
|
Contributor
Author
There was a problem hiding this comment. No objections. I was initially avoiding adding a lot of file metadata for which I didn't feel there was a hard requirement.
Contributor
There was a problem hiding this comment. mime/type is exactly what you're looking for here so that would be my recommendation. otherwise anyone that consumes this has to do a mime/type -> file_type mapping otherwise.
Contributor
There was a problem hiding this comment. I agree, |
||
| "type": "string", | ||
| "enum": [ | ||
| "pdf", | ||
| "doc", | ||
| "jpg" | ||
| ] | ||
| }, | ||
| "file_name": { | ||
| "description": "Original name of the uploaded file", | ||
| "type": "string" | ||
| }, | ||
| "meta": { | ||
| "$ref": "meta.json" | ||
| }, | ||
| "links": { | ||
| "type": "object", | ||
| "properties": { | ||
| "dispute": { | ||
| "description": "The dispute your customer has filed with their bank associated with this debit", | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ], | ||
| "pattern": "DT[a-zA-Z0-9]{16,32}" | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "dispute" | ||
| ] | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "id", | ||
| "href", | ||
| "created_at", | ||
| "updated_at", | ||
| "url", | ||
| "file_type", | ||
| "file_name", | ||
| "meta", | ||
| "links" | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-04/schema#", | ||
| "type": "object", | ||
| "properties": { | ||
| "links": { | ||
| "type": "object", | ||
| "properties": {} | ||
|
Contributor
There was a problem hiding this comment. this needs a |
||
| }, | ||
| "meta": { | ||
| "type": "object" | ||
| }, | ||
| "dispute_documents": { | ||
| "items": { | ||
| "$ref": "_models/dispute_document.json" | ||
| }, | ||
| "type": "array", | ||
| "minItems": 0, | ||
| "uniqueItems": true | ||
| } | ||
| }, | ||
| "required": [ | ||
| "dispute_documents" | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveklabnik do you like dispute_documents vs evidence? What's your reasoning for choosing one over the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pluralization of
evidencewas what steered me away from using it as a resource name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"evidence" can be evidence of anything, "dispute document" is extremely unambiguous.
I don't feel particularly strongly about it, though.