Implement per-object top,bottom,initial flow ratios#9809
Draft
logikal wants to merge 1 commit intobambulab:masterfrom
Draft
Implement per-object top,bottom,initial flow ratios#9809logikal wants to merge 1 commit intobambulab:masterfrom
logikal wants to merge 1 commit intobambulab:masterfrom
Conversation
lanewei120
requested review from
ShanCang-BamBu and
zhimin-zeng-bambulab
and removed request for
ShanCang-BamBu
zhimin-zeng-bambulab
approved these changes
Mar 13, 2026
tangketan
requested changes
Mar 16, 2026
Collaborator
tangketan
left a comment
tangketan
left a comment
There was a problem hiding this comment.
- There is no role called "bottom solid infill"; it's a bit strange to add the bottom_solid_infill_flow_ratio parameter. Please provide a use-case where the new parameter is necessary.
- For the first layer of an object, the flow rate is multiplied twice (initial_layer_flow_ratio and bottom_solid_infill_flow_ratio), which is confusing for many people. Is it better to only apply one of the parameters?
Contributor
Author
|
Apologies, this was meant to still be a draft, and I'm still experimenting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building locally on osx breaks with every release, it feels like, so pushing to GH just to get the action to build for me.