Repository navigation
feat(herdr): alert on spaces whose agent finished unseen - #88
Conversation
The waiting alert only fired for blocked agents, which are rare; the everyday "waiting on you" state is done (finished while unseen). A new waits() helper covers both and drives the pulse, the machine count and the space row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A9D7ph123Jn8iB1eGbr8Nz
Fleet review (glm)Lens: requirements + adversarial. The PR unifies the 'someone is waiting on the person' signal behind a waits(status) helper that now also fires for done, applying it consistently to the pulse timer, the machine-header border and count, and the row border with the '● te espera' pill. I read the full file at the reviewed head and verified every former status === "blocked" call site was converted (pulse timer line 79, header count line 253, row line 322); glyph() semantics for done are unchanged from before (it already rendered ● for done). The done state still reuses the blocked visual language (t.blocked pulse color, blocked-bg pill, and the 'waiting on the person' comment), which matches the PR's stated intent of treating done as 'finished while the user wasn't looking'. No linked issue with acceptance criteria was attached, so I reviewed against the PR's own summary and test plan; the claimed clear-to-idle-on-view behavior lives outside this mod and is not touched by the diff. No defects found. Suggestion (1)
Question (1)
Verdict: ready to merge |
Summary
doneas well asblocked.doneis Herdr's "finished while the user wasn't looking" state, the common case of an agent waiting on the person; it clears toidleonce the space is viewed.waits(status)helper drives the pulse timer, the machine count and the row.Test plan
node --checkon the mod🤖 Generated with Claude Code
https://claude.ai/code/session_01A9D7ph123Jn8iB1eGbr8Nz