test: sync forge-std-rev to v1.16.2 to fix forge-std revision-mismatch warning#52
Closed
stephancill wants to merge 1 commit into
Closed
test: sync forge-std-rev to v1.16.2 to fix forge-std revision-mismatch warning#52stephancill wants to merge 1 commit into
stephancill wants to merge 1 commit into
Conversation
The test template (crates/test-utils/src/util.rs) force-checks-out
FORGE_STD_REVISION (= testdata/forge-std-rev) into lib/forge-std, while
'forge init' writes a foundry.lock pinning forge-std at bf647bd6 (v1.16.2).
Our pin was stale at 620536fa (Apr 2026), so 'forge build' emitted:
Warning: Dependency 'lib/forge-std' revision mismatch:
expected 'bf647bd6046f2f7da30d0c2bf435e5c76a780c1b',
found '620536fa5277db4e3fd46772d5cbc1ea0696fb43'
That warning breaks the no-warning / snapshot CLI tests:
- build::build_no_warning_without_soldeer_lock
- cmd::can_clean_without_warnings
- test_cmd::repros::issue_9272
Sync the pin to bf647bd6 to match upstream foundry-rs/foundry's
testdata/forge-std-rev, so the checked-out rev matches the lock.
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
Contributor
Author
|
Folding this into the CI maintenance PR #51 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
base-anvil-forkCI'stest / test alljob fails on three CLI tests:forge::cli build::build_no_warning_without_soldeer_lockforge::cli cmd::can_clean_without_warningsforge::cli test_cmd::repros::issue_9272All three fail for the same reason —
forge buildemits a spurious warning:The first two assert zero warnings;
issue_9272asserts an exact stderr snapshot and the warning is prepended as an extra line.Root cause
The shared test template (
crates/test-utils/src/util.rs) runsforge init(which writes afoundry.lockpinning forge-std atbf647bd6, i.e. v1.16.2) and then force-checks-outFORGE_STD_REVISION(=testdata/forge-std-rev) intolib/forge-std. Ourtestdata/forge-std-revwas stale at620536fa(Apr 2026), so the checked-out rev no longer matched the lock andcheck_foundry_lock_consistencywarned.Solution
Bump
testdata/forge-std-rev620536fa → bf647bd6, matching upstream foundry-rs/foundry'stestdata/forge-std-rev(forge-std v1.16.2). Now the template checkout matches the lock forge writes, so no mismatch warning is emitted.One-line change; format preserved (40-byte SHA, no trailing newline). Validated the target value against upstream foundry's pin; the
test / test alljob on this PR exercises the fix end-to-end.Not addressed
test / test external(ext_integration::gunilev,convex_shutdown_simulation) fork Ethereum mainnet over a public RPC and are environmental flakes, unrelated to this change.PR Checklist