Skip to content

fix(prover-nitro-enclave): use Linux-only deps for real main#1757

Merged
0x00101010 merged 1 commit intobase:mainfrom
DoddHazlittlrduq:fix/prover-nitro-enclave
Mar 30, 2026
Merged

fix(prover-nitro-enclave): use Linux-only deps for real main#1757
0x00101010 merged 1 commit intobase:mainfrom
DoddHazlittlrduq:fix/prover-nitro-enclave

Conversation

@DoddHazlittlrduq
Copy link
Copy Markdown
Contributor

@DoddHazlittlrduq DoddHazlittlrduq commented Mar 29, 2026

issue:

The binary's async main, eyre return type, and NitroEnclave import are #[cfg(target_os = "linux")]; non-Linux builds only compile a panic stub.

Put eyre, base-proof-tee-nitro-enclave, and tokio under [target.'cfg(target_os = "linux")'.dependencies] so cargo-udeps does not flag them on other hosts.

Summary

Scope base-prover-nitro-enclave runtime dependencies to Linux only, matching main.rs cfg split.

Motivation

On non-Linux targets, only the panic!(...) stub main is compiled; tokio, eyre, and base-proof-tee-nitro-enclave are unused in depinfo. Unconditional [dependencies] causes cargo udeps false positives on macOS and similar CI matrices.

Changes

  • bin/prover/nitro-enclave/Cargo.toml: replace top-level [dependencies] with [target.'cfg(target_os = "linux")'.dependencies] for eyre, base-proof-tee-nitro-enclave, and tokio (waterfall-sorted).

Verification

  • cargo check -p base-prover-nitro-enclave
  • RISC0_SKIP_BUILD_KERNELS=1 cargo +nightly udeps --locked -p base-prover-nitro-enclave --all-features --all-targets

The binary's async main, eyre return type, and NitroEnclave import are
#[cfg(target_os = "linux")]; non-Linux builds only compile a panic stub.

Put eyre, base-proof-tee-nitro-enclave, and tokio under
[target.'cfg(target_os = "linux")'.dependencies] so cargo-udeps does not
flag them on other hosts.
@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Mar 29, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 29, 2026

@DoddHazlittlrduq is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@0x00101010 0x00101010 enabled auto-merge March 30, 2026 04:58
@0x00101010 0x00101010 added this pull request to the merge queue Mar 30, 2026
Merged via the queue into base:main with commit 210b0fd Mar 30, 2026
23 of 24 checks passed
Ocheretovich pushed a commit to Ocheretovich/base that referenced this pull request Mar 30, 2026
The binary's async main, eyre return type, and NitroEnclave import are
#[cfg(target_os = "linux")]; non-Linux builds only compile a panic stub.

Put eyre, base-proof-tee-nitro-enclave, and tokio under
[target.'cfg(target_os = "linux")'.dependencies] so cargo-udeps does not
flag them on other hosts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants