fix(prover-nitro-enclave): use Linux-only deps for real main#1757
Merged
0x00101010 merged 1 commit intobase:mainfrom Mar 30, 2026
Merged
fix(prover-nitro-enclave): use Linux-only deps for real main#17570x00101010 merged 1 commit intobase:mainfrom
0x00101010 merged 1 commit intobase:mainfrom
Conversation
The binary's async main, eyre return type, and NitroEnclave import are #[cfg(target_os = "linux")]; non-Linux builds only compile a panic stub. Put eyre, base-proof-tee-nitro-enclave, and tokio under [target.'cfg(target_os = "linux")'.dependencies] so cargo-udeps does not flag them on other hosts.
Collaborator
✅ Heimdall Review Status
|
|
@DoddHazlittlrduq is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
0x00101010
approved these changes
Mar 30, 2026
Ocheretovich
pushed a commit
to Ocheretovich/base
that referenced
this pull request
Mar 30, 2026
The binary's async main, eyre return type, and NitroEnclave import are #[cfg(target_os = "linux")]; non-Linux builds only compile a panic stub. Put eyre, base-proof-tee-nitro-enclave, and tokio under [target.'cfg(target_os = "linux")'.dependencies] so cargo-udeps does not flag them on other hosts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue:
The binary's async main, eyre return type, and NitroEnclave import are #[cfg(target_os = "linux")]; non-Linux builds only compile a panic stub.
Put eyre, base-proof-tee-nitro-enclave, and tokio under [target.'cfg(target_os = "linux")'.dependencies] so cargo-udeps does not flag them on other hosts.
Summary
Scope
base-prover-nitro-enclaveruntime dependencies to Linux only, matchingmain.rscfg split.Motivation
On non-Linux targets, only the
panic!(...)stubmainis compiled;tokio,eyre, andbase-proof-tee-nitro-enclaveare unused in depinfo. Unconditional[dependencies]causescargo udepsfalse positives on macOS and similar CI matrices.Changes
bin/prover/nitro-enclave/Cargo.toml: replace top-level[dependencies]with[target.'cfg(target_os = "linux")'.dependencies]foreyre,base-proof-tee-nitro-enclave, andtokio(waterfall-sorted).Verification
cargo check -p base-prover-nitro-enclaveRISC0_SKIP_BUILD_KERNELS=1 cargo +nightly udeps --locked -p base-prover-nitro-enclave --all-features --all-targets