fix: implement GlobalID locator model_class#317
Open
FrancescoK wants to merge 1 commit into
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR updates ActiveRecord::Tenanted::GlobalId::Locator to comply with the GlobalID 1.4 requirement for a #model_class method, avoiding deprecation warnings and keeping locator behavior consistent with tenant-safety checks.
Changes:
- Add
ActiveRecord::Tenanted::GlobalId::Locator#model_classand routelocatethrough it. - Update tenant context safety checks to use the locator’s resolved model class.
- Add a unit test asserting
#model_classreturns the expected model constant.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lib/active_record/tenanted/global_id.rb |
Introduces #model_class and refactors locate/tenant safety logic to use it. |
test/unit/global_id_test.rb |
Adds coverage for the new #model_class behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Version 1.4 of the globalid gem now requires a #model_class method and surfaces deprecation warnings if missing. This commit addresses that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.4 of the globalid gem now requires a #model_class method and surfaces deprecation warnings if missing. This commit addresses that in a narrow fashion. A version inheriting from GlobalID’s BaseLocator class is in #318 instead.