Fix fingerprint setup crash when libfprint-git is installed#6121
Open
mounis-bhat wants to merge 1 commit into
Open
Fix fingerprint setup crash when libfprint-git is installed#6121mounis-bhat wants to merge 1 commit into
mounis-bhat wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The
omarchy-pkg-present libfprintcheck returnstrueiflibfprint-gitis installed because it "provides"libfprint.The script then tries to remove the literal
libfprintpackage withpacman -Rdd. This triggers asudoprompt for existing fingerprint users, fails with atarget not founderror, and abruptly crashes the script due toset -e.Fix
Replaced the check with
pacman -Qq | grep -Fxq "libfprint"to ensure it only attempts removal if the exact, literallibfprintpackage is installed.