Skip to content

Fix fingerprint setup crash when libfprint-git is installed#6121

Open
mounis-bhat wants to merge 1 commit into
basecamp:devfrom
mounis-bhat:fix-fingerprint-setup
Open

Fix fingerprint setup crash when libfprint-git is installed#6121
mounis-bhat wants to merge 1 commit into
basecamp:devfrom
mounis-bhat:fix-fingerprint-setup

Conversation

@mounis-bhat

Copy link
Copy Markdown

Issue

The omarchy-pkg-present libfprint check returns true if libfprint-git is installed because it "provides" libfprint.

The script then tries to remove the literal libfprint package with pacman -Rdd. This triggers a sudo prompt for existing fingerprint users, fails with a target not found error, and abruptly crashes the script due to set -e.


Fix

Replaced the check with pacman -Qq | grep -Fxq "libfprint" to ensure it only attempts removal if the exact, literal libfprint package is installed.

Copilot AI review requested due to automatic review settings June 22, 2026 09:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants