fix: multi-monitor window highlighting in slurp capture#6122
Open
Liran-shternberg wants to merge 1 commit into
Open
fix: multi-monitor window highlighting in slurp capture#6122Liran-shternberg wants to merge 1 commit into
Liran-shternberg wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes multi-monitor window highlighting in slurp.
The Issue: get_rectangles() only queried the focused monitor. Moving the cursor to a second or third monitor slurp was blind to the windows of that monitor and the window capture feature didn't work(meaning you needed to click and drag manually).
The Fix:
Updated the logic to return geometries for all connected monitors.
Built an array of active workspace IDs across all screens and filtered the hyprctl clients list to match.
Optimized the data passing using jq --argjson.