Fix inherited text shadows in Waybar tooltips#6133
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fcb557c14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| waybar_style="$HOME/.config/waybar/style.css" | ||
|
|
||
| if [[ -f $waybar_style ]] && ! grep -q "text-shadow: none" "$waybar_style"; then |
There was a problem hiding this comment.
When a user already has any text-shadow: none in their copied Waybar stylesheet (for example from a local module-specific tweak), this whole migration is skipped before adding the new tooltip * override. The default fix relies on the tooltip-specific selector to beat inherited GTK tooltip styling, so those users keep the doubled tooltip text even though the migration is recorded as applied; check for the tooltip rule itself or insert the missing rules independently.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR addresses GTK text-shadow styling leaking into Waybar tooltips by explicitly disabling text shadows in Omarchy’s base Waybar CSS and adding a migration to patch existing user-copied Waybar configs.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Disable inherited
text-shadowglobally in the base Waybarstyle.css. - Explicitly disable
text-shadowfortooltipand its contents to prevent doubled-looking tooltip text. - Add a migration intended to update already-copied user Waybar styles.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| migrations/1779713467.sh | Adds a migration to patch existing user-copied Waybar CSS to disable inherited text shadows. |
| config/waybar/style.css | Updates the default Waybar CSS to explicitly disable text shadows (including tooltip-specific overrides). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| waybar_style="$HOME/.config/waybar/style.css" | ||
| marker="omarchy:disable-text-shadow" | ||
|
|
||
| if [[ -f $waybar_style ]] && ! grep -qF "$marker" "$waybar_style"; then |
|
A kind heads-up :) The upcoming Omarchy 4 release moves away from Waybar in favour of a new quickshell based solution. |
Summary
Why
On some themes, GTK text-shadow styling can leak into Waybar tooltips and make dropdown text look doubled. Omarchy Waybar themes only define colors, so the base Waybar CSS should explicitly opt out of text shadows.
Validation
git diff --checkbash -n migrations/1779713467.shScreenshots
Before
After