Add lock input feedback#6137
Open
FilipHarald wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds visual input feedback to the lock screen password field by pulsing the input border on each password edit, improving usability for long passwords where dot animations are less effective.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Pulse the lock input field border when
passwordTextchanges (non-empty). - Dynamically adjust
BorderSurface.borderSpecduring the pulse animation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+118
to
+120
| borderSpec: root.inputBorderPulseWidth > 0 && !root.errorState | ||
| ? Border.surfaceSpec("lock", "border-active", Color.lock.borderActive, root.outlineThickness + root.inputBorderPulseWidth, "border-alpha") | ||
| : root.inputBorderSpec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds animation so that long passwords still gives visual feedback on inputs. Also did a PR to hyprlock in #6131 . This one is unfortunately a little bit more imposing. I found it easier to scale the border than animate the chars. Happy for feedback!
Also started discussion here: #6130
20260625_155223.mp4