Remove --promote flag from model push#19
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the --promote flag from baseten model push, standardizing on --environment production for production pushes and simplifying flag handling in the model push command.
Changes:
- Removed
--promotefromModelPushFlagsand eliminated promote-specific handling/validation in the model push implementation. - Updated E2E coverage to use
--environment productionfor production pushes. - Adjusted unit tests by removing validation specific to the deleted
--promoteflag.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cmd/command.model.go |
Removes the --promote flag from the CLI flag definitions for model push. |
internal/cmd/command.model_push.go |
Deletes promote/environment mutual-exclusion validation and promote-to-production flag handling. |
internal/cmd/command.model_push_test.go |
Removes the unit test that asserted --promote and --environment were mutually exclusive. |
internal/e2e-tests/model_test.go |
Updates E2E calls to push to production via --environment production instead of --promote. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marius-baseten
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What
--promoteis just shortcut for--environment productionand we don't want the separate flag anymore.💻 How
Removed the
--promoteflag🔬 Testing
Adjusted tests