Skip to content

Remove --promote flag from model push#19

Merged
cretz merged 2 commits into
mainfrom
cretz/remove-promote-flag
Jun 22, 2026
Merged

Remove --promote flag from model push#19
cretz merged 2 commits into
mainfrom
cretz/remove-promote-flag

Conversation

@cretz

@cretz cretz commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

🚀 What

--promote is just shortcut for --environment production and we don't want the separate flag anymore.

💻 How

Removed the --promote flag

🔬 Testing

Adjusted tests

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the --promote flag from baseten model push, standardizing on --environment production for production pushes and simplifying flag handling in the model push command.

Changes:

  • Removed --promote from ModelPushFlags and eliminated promote-specific handling/validation in the model push implementation.
  • Updated E2E coverage to use --environment production for production pushes.
  • Adjusted unit tests by removing validation specific to the deleted --promote flag.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
cmd/command.model.go Removes the --promote flag from the CLI flag definitions for model push.
internal/cmd/command.model_push.go Deletes promote/environment mutual-exclusion validation and promote-to-production flag handling.
internal/cmd/command.model_push_test.go Removes the unit test that asserted --promote and --environment were mutually exclusive.
internal/e2e-tests/model_test.go Updates E2E calls to push to production via --environment production instead of --promote.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cretz cretz merged commit d62da41 into main Jun 22, 2026
3 checks passed
@cretz cretz deleted the cretz/remove-promote-flag branch June 22, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants